Found an interesting issue where the metal bits gotten from chiseling broken items from Smithing Plus and the metal bits returned from forging from Thrifty Smithing don't stack. They have the same name and look identical just don't stack.

When smelted down into ingots they turn into regular ingots, and you can even smelt different bits of the same metal type into a single ingot, with the weird exception of iron bits into the bloomery, you need to only use one of the stacks, but then the resulting iron ingots don't stack with normal iron ingots.

Posting this comment on both mods, cause I'm not sure where, or even what, exactly the issue is.

I used a chisel and a damaged spear to synthesize, and the result was a intact spear (durable 133). I didn't expect to get copper ore, but what's even more amazing is that I used a damaged spear and a chisel that had already been repaired once to synthesize, and I got two chisels. When I put this second chisel in the synthesis column, it disappears. I used Smithing Plus 1.1.1 and Thrifty Smithing 1.2.0

eggdropsoap Calamity Yes you heat bits and nuggets in a crucible, I could make it possible in a forge but that would require some work and as a feature, although it looks cool, it is questionable since it is less viable than using the crucible, which can use fuels like wood and is faster in comparison. I cannot ban heating in crucibles either as that would invalidate smelting entirely.

@Calamity Ah, ok. I see the difference now in these two bullet points from the description, but now I don't understand the first bullet point:

• Can smith with metal bits and native (copper, gold, silver) nuggets
• Can add bits to ongoing smithing projects (work items)

I figured if I can smith with nuggets, I can repair with nuggets. But now I don't understand how smithing with nuggets works at all, since they can't be put in the forge?

Edit: Aha! You can smith with native metal nuggets. You just have to heat them to working temperature in a crucible instead of a forge.

@eggdropsoap

you need to use copper bits not native nuggets.

Hi! I can't for the life of me figure out how to repair a broken copper pickaxe head. I can heat the broken copper pickaxe head in the forge just fine, but I can't figure out how to begin repairing it.

I can't add native copper nuggets to the forge to fill in the 6 missing voxels. I could heat up and then add a whole ingot to the broken head work item, but then I might as well just make a new pickaxe head with the ingot, and ignore the broken one or chisel it apart.

I'm sure I'm just missing something about the repair process. What am I missing?

Do you plan on adding features other mods have like thrifty smithing?

it would be nice to have all of them in 1 package if that makes sense. especially if the others dont update or build upon.

i dont think thrift smithing gives iron bloom bits which sucks

jayu Thanks

Ghostwheel they are just vanilla work items, you can chisel them to bits

Can we, and how if yes, smelt broken tool heals into bars? On it it says it smelts into 1 ingot, but it doesn't work in a crucible or forge. Bloomery?

Thank you! I've only recently started to use this mod, so I can't speak on my enjoyment of the features, but I really appreciate the work you put into compatibility for it.

gndrneutralnoun whoops, that was my bad, forgot to remove a debug test. Fixed now.

Hey, since I started using the 1.1.2 version, I get exactly 2 of everything I smith, even if it would usually output more than 1 item. i.e. 4 nail strips recipe = just 2 nail strips. 1 metal plate recipe = 2 metal plates. I tested this with all mods disabled except for Smithing Plus and it still happened.

jayu

Ohhhhhh! It seems to be fixed! Thank you so much for the help!!!!! amazing moooodddddddd

Veraldur from what I could see in my testing, all these issues are fixed in the new version I put out

jayu

Hi, we’ve been testing, and the same process happens when combining the head and handle. Another player without skills encountered the following log on the server; it doesn’t mention Xskills. On the other hand, we noticed that when we put a stack of 2 or more repaired heads and several sticks below, it creates the repaired tools until it reaches the value of 0. At that point, the repaired pickaxe can’t be extracted from the crafting slot; it stays at 0. (The person who tested it in the log has no blacksmith levels in Xskills).

Log server other player

Veraldur the issue can be fixed, I had a look at the XSkills code and am about to test if my fix works. If it does, I will upload it. If not, I will try to ask the XSkills author for a fix on their side.

Edit: In fact, I think I fixed it, did you have the metalworking Blacksmith skill? That seemed to be the issue, but now the pickaxe quality can transfer over properly.

Now I need to filter the new unfinished content I added so I can upload the mod.

jayu

I think this is the problem; both mods are incompatible. The worst part is that even after uninstalling Xskills and Xlib, the user's access remains corrupted. Even after uninstalling all inventory mods, it only works again when I remove Smithing Plus from the server.
I removed Smithing Plus, I was able to log back in, and now I’m going to permanently delete Skills because I prefer what Smithing does. Cheers, and thanks for everything.

EDIT
I uninstalled the Xlib and Xskills mods in a previous backup, but the error happened again. It occurs exactly when I try to add the stick to a repaired axe head in the crafting menu. When I click on the repaired pickaxe head with the handle in the output slot, the error occurs. After that, it only allows me to connect to the server if I have removed the Smithing Plus mod. If I remove it before combining the pickaxe head and the handle, it works perfectly. I don’t know, it’s kind of strange. I apologize if I'm being bothersome. I think I know how to handle it temporarily by uninstalling and reinstalling every time it happens. Cheers. Here’s the error log without Xskill or Xlib installed.

New server log

Veraldur yeah it seems like the problem is with XSkills, all the errors are thrown from the XSkills side. The reason you still get an error when you remove it is that it replaces the hotbar inventory somehow.

I will see what I can do on my side, if not will have to ask the XSkills author for a resolution on that side instead.
Btw, you do not have to uninstall the mod, turning off tool repair in the config would also disable the patch that is causing you issues.

jayu

Hello again, I managed to replicate the user’s error. It happens exactly after repairing tools like copper picks. It occurs when attempting to attach the head to the handle; the head isn’t completely cool yet. From the server log, I infer a possible incompatibility between this mod and xSkills?

The crash is severe; it doesn’t let me reconnect to the server. The server immediately rejects my connection. There’s no way to get back in. The only option is to remove the Smithing Plus mod.

Server Crash  
Client Crash

I’m attaching the logs.

Edit: the server issue whe im try conect:
I tried completely uninstalling xSkills, but the error remains the same. I understand that it doesn’t seem to be an issue with Smithing Plus. What seems odd to me is that I can only log in when Smithing Plus is uninstalled from the server.

Server issue

ZephyrCuga if you can send client-debug.txt and server-debug.txt from VintagestoryData/Logs using a pastebin. What's your mod list? Did this happen after crafting it back? Could be an error when I transfer the attributes due to something else interfering with it.

Post-repair scythe is haunted. will not exist outside of my inventory. perpetually craftable but its soul will never leave my crafting window. I wish I was joking.

jayu

Now that you mention it, and after reviewing, the player noted that the crash happened right when they tried to store broken bronze pickaxe and hammer heads. It’s possible it was a synchronization issue, as we’ve had some mod alerts regarding syncing. We’ll continue playing with Smithing Plus, and I’ll personally try to repeat those specific scenarios. I’ll report back if anything else happens. Thanks again for taking the time to investigate this.

Veraldur ok thank you for the additional information, if there was a broken head involved then it must be this mod, although it is weird since the code uses base game features and doesn't touch sounds. I will try to investigate, but I might not be able to reproduce it. Thank you again for the report and please do report if this happens again.

Edit: Rereasdng your comment, it seems you were able to reproduce the issue? Did you place the toolhead in a vessel to do that? Does that work with any toolhead and/or vessel, or just the supposedl corrupted one? I do not get any crash when putting broken heads into an urn, when on a server

The crash itself seems to have to do with rendering the inventory contents, and it doesn't find something that it thinks should be there. Maybe some it's a weird synchronisation issue? Or the player doesn't have the mod installed properly on their client.

jayu

Firstly, thank you for your response and for this fantastic mod. I’m new to Vintage Story, and I set up a local server to play with friends as we’re still getting the hang of the game mechanics. So, it's likely the issue isn’t related to this mod. However, the player experiencing the bug could only log back into the server after we uninstalled Smithing Plus. After reviewing the client logs, there seems to be an inventory-related error, though it’s probably unrelated to the mod. Nevertheless, it was frustrating for that player to be locked out.

Before the errors appeared in the logs, we had removed several inventory-related mods from the server, such as CarryOn and BetterFirePit. Despite this, the player with the bug could only reconnect after uninstalling Smithing Plus. All other players were having a normal experience. The player with the bug reported that the game crashed right after storing a damaged axe head and a damaged hammer head in a ceramic urn. After removing Smithing Plus, that urn became inaccessible for any player and could only be destroyed.

I’ve attached the logs. Thank you again, and even though we had only run Smithing Plus for a day, I think it's one of the most immersive mods out there. We hope to be able to use it again soon.

Since the server kept running after all of this, there’s nothing unusual in the server log, and no errors mention Smithing Plus. This makes me think the issue wasn’t with the mod itself; it just caused a strong bug for that one player, which we resolved by uninstalling Smithing Plus.

Apologies for my lack of experience with this kind of issue. I’m learning as I go, and I have to emphasize that this mod is amazing—everyone should use it.

LOGS
Client Crash
Client Debug   (The player normally plays on Windows, but I conducted these tests on a Linux system. The same error appeared on both systems.)

Veraldur well we have a problem because I do not touch neither sounds (OpenAL) nor containers of any kind. The log you show does not display any error that is related to my mod. Without any additional information (crash logs that show a stacktrace) I cannot do anything about this. Even with it, I find it hard to think that the mod is the direct cause, at worst it seems like a weird vanilla bug or mod interaction to me, but I could be wrong I guess.

If you can, please send the full files client-crash.txt, client-debug.txt and server-debug.txt after a crash using a pastebin please.

Also what and how did the player "interact" with, and what was being done when smithing? Again I doubt the mod is the direct cause, but there might be some obscure bug hidden in here.

Hi!!! First! ty for this great mod.

Issue Summary: Critical client crash while accessing a container with Smithing Plus mod enabled.

Description:
A player experienced a crash while accessing a container during smithing activities. After the crash, the player was unable to reconnect, and the client displayed multiple OpenAL errors related to InvalidName for the sound game:music/roots.ogg. Attempts to adjust the sound volume (setvolume(val)) resulted in repetitive OpenAL errors indicating "Invalid source ID 1." Other players could still access the container without issues, but the affected player remained unable to reconnect.

Temporary Resolution:
Uninstalling the Smithing Plus mod allowed the affected player to reconnect, but the container itself became inaccessible to all players until it was destroyed.



27.10.2024 23:36:31 [Client Warning] OpenAL Error during setvolume(val) of sound game:music/roots.ogg: InvalidName
...
27.10.2024 23:36:40 [Client Fatal] Exception in async LoadSounds thread:
27.10.2024 23:36:40 [Client Error] Exception: Object reference not set to an instance of an object.
at csogg.Page.serialno()
at Vintagestory.Client.NoObf.OggDecoder.OggToWav(Stream ogg, IAsset asset) in VintagestoryLib\Client\ClientPlatform\ClientNative\OggDecoder.cs:line 528
...

Additional Context:

• The issue seems linked to the audio system (OpenAL) and object references within the Smithing Plus mod.
• Other players have reported similar OpenAL errors when certain mods attempt to handle audio assets asynchronously.

Suggested Actions:

1. Investigate compatibility between Smithing Plus and OpenAL sound handling.
2. Review error handling in asynchronous sound loading to improve recovery from invalid audio references.
3. Provide guidance for players experiencing persistent OpenAL errors.

this is a gpt o1 analisis.


my versión:

While performing some smithing actions, a player attempted to access a container, which caused the client to crash. After this crash, the player could no longer reconnect to the server, encountering repeated OpenAL errors with messages like:


OpenAL Error during setvolume(val) of sound game:music/roots.ogg: InvalidName
[ALSOFT] Error generated on context 0x7dbb4008ca20, code 0xa001, "Invalid source ID 1"


Other players were able to interact with the container without any issues, but the affected player remained unable to reconnect. The only solution was to uninstall the Smithing Plus mod in server side, allowing the player to log back in. However, no player could access the container afterward until it was destroyed.

TY! great mod