DanaCraluminum I think it may be related to a different mod. I tried disabling the Banners and I still can't create a new creative world or load into an existing creative one. I also can't create a homo sapiens world so I think I need to do some more testing to figure out which mod is the real culprit. Sorry about the confusion!

dangerousb Does it happen when you force quit before world is fully loaded?

Hi, I love the mod! I'm still on 1.19.8 using version 0.33.1 and when I tried to make a new creative world I got this error:

15.11.2024 19:25:17 [Error] Exception: Object reference not set to an instance of an object.
at Vintagestory.API.Util.ObjectCacheUtil.GetOrCreate[T](ICoreAPI api, String key, CreateCachableObjectDelegate`1 onRequireCreate) in VintagestoryApi\Util\ObjectCacheUtil.cs:line 22
at Flags.ItemBannerPattern.get_Meshes() in C:\Users\dana_\Source\Repos\Craluminum-Mods\Banners\Banners\src\Item\ItemBannerPattern.cs:line 17
at Flags.ItemBannerPattern.OnUnloaded(ICoreAPI api) in C:\Users\dana_\Source\Repos\Craluminum-Mods\Banners\Banners\src\Item\ItemBannerPattern.cs:line 33
at Vintagestory.Server.ServerMain.Stop(String reason) in VintagestoryLib\Server\ServerMain.cs:line 1161

Interestingly, I am able to load into my survival world with the same mods enabled.

thanks! no crash now

Lacero Try new version

I see you said the mod needed no updates for 1.20 below but I think there's a problem, had a crash when trying to use a vanilla raft

Running on 64 bit Windows 10.0.19045.0 with 32682 MB RAM
Game Version: v1.20.0-pre.11 (Unstable)
10/11/2024 14:44:39: Critical error occurred in the following mod: flags@0.33.1
Loaded Mods: BetterGrass@0.0.3, bettertraders@0.0.7, buzzwords@1.7.0, combatoverhaul@0.0.44, manidae@1.0.5, rhinocerotidae@1.0.6, sirenia@1.0.8, spheniscidae@1.0.0, millwright@1.1.7, cbetterfertilizer@1.2.0, primitivesurvival@3.7.0, translocatorengineeringredux@1.5.4, game@1.20.0-pre.11, vsimgui@1.1.7, vtr@4.0.4, alchemy@1.6.39, apegrapes@1.1.2, armory@0.0.5, egocaribautomapmarkers@4.0.0, flags@0.33.1, betterruins@0.3.9, carryon@1.8.0-pre.1, configlib@1.3.17, fendragonbcs@0.1.2, hydrateordiedrate@1.5.3-pre.11, creative@1.20.0-pre.11, survival@1.20.0-pre.11, wildgrass@1.1.2, shearlib@1.0.2, wool@1.2.2
System.MissingMethodException: Method not found: 'Void Vintagestory.GameContent.EntityShapeRenderer.MarkShapeModified()'.
at Flags.EntityBehaviorBoatWithBanner.OnEvent(String eventName, EnumHandling& handling, IAttribute data)
at Vintagestory.Client.NoObf.ClientEventAPI.PushEvent(String eventName, IAttribute data) in VintagestoryLib\Client\API\ClientEventAPI.cs:line 476

Snowfall94 I will add it only once this idea gets popular.

Here is how much you could fit on it:

It'd be neat if you could use a feather and ink to write on them. So you could make a custom banner with words on it, so you could do banners for shops and stuff. Like having a custom banner with the words "Cloak and Stagger" hanging out front of your tavern (For multiplayer/Roleplay reasons)

Just suggesting this because I don't see anything that says "hey, you can write words on these" and idk if you like the idea, but personally I think it'd be neat

The mod survived 1.20, no updates needed. Actually, I need to add support for new sailboats and elk

ssunny2008 Are you using 0.33.0 version? Is edit mode for banner enabled? Press Ctrl + Shift + B to open config and then toggle Extra info, what does it say about edit mode?

Hiho,

are there any known bugs so far? I got a banner (plain) version, but i´m not able to dye it. I´ve the pattern in my offhand and tried it with different dyes in a bowl but nothing happens sadly.

Greetings

DanaCraluminum i could screenshare via discord sometime!

SkullyDog Could you send screenshot somewhere? Also what banner you used and what patterns you expected it to unlock?

I seem to have an issue where learning the banner pattern is only available for that banner i learned it from. is there something i may be doing wrong?

endey Could you join official vs discord and ping me in "mods" channel?

yeah sure, my discord is endeyfire.
im under the mild assumption right now that theres a significant mod conflict between your mod and something else. might wanna get the modlist from the other dude who said his game was stuttering, and do a comparison with mine.

endey I'm debugging the mod non-stop for few days already and still haven't found the source of lags, could you help me in discord with this?

im getting lag spikes every second with this mod. which is a shame.

My ideas- sadly- often do. Thanks for reading it, though. :)

SniperGecko Both these solutions require too much work

DanaCraluminum

The following idea goes to solving the issue you brought up but through its own mod, I'd think.
The ability to alter the offered trade stock by way of.. almost making requests.

I can think of two ways right-off; having a small special-scroll holder in which you can place a scroll with a desired 'focus' (Purchase Order). For example, you might write a couple different PO scrolls, Artisan:Tapestry, Artisan:Storage, Artisan:Flowerpot. A particular Artisan trader may have a scroll holder than can hold only one scroll or two or many.
Let's say you place an Artisan:Storage Purchase Order into their scroll-holder. Check back after a day or two and the scroll is gone and half the trades have been replaced with a variety of Storage Vessels- and what luck; the artwork you wanted is available! You got what you wanted so you place an Artisan:Wallpaper PO into the scroll-holder. A few days later you see that the wallpaper you wanted to sell is not there, darn. Adding another Artisan:Wallpaper would change the stock options again; or just leaving it for several days will revert his trades back to the original options.

A mod like this could be used to add support for many mods simply through adding their PO as part of their mod, if a Purchase Order mod were in a pack. For this mod you could have Artisan:Banners. Then the default-trades are unaffected unless a player opts in. Then once they have what they need, the trades revert anyway.

The second way would be placing some block near their wagon outside of their claim to change their trades. Less interesting but would be affective. Perhaps just placing banners around their camp to add Banner trades and removing them to remove the trades.

SiiMeR I can't reproduce lag spikes in single player

The latest version (v0.30.0) causes a ton of lag on my server. The frametimes become extremely unstable and the fps is lower overall. Reverting to v0.29.1 fixed the issue immediately. 

Looking at logs and performance graphs, I didn't notice anything odd.

Jenpai I don't want to add new traders for few things, any ideas how to fix this other way? I tried to make them rarer in trader window but then they leave empty slots

Couldn't help but notice that banners really clog up merchant's stock; Might be a good idea to have their own merchant?

Soon

Please make a Hexagon or Honeycomb patern!

Epic, but I don't play the game any more, I just check in every now and then to make sure none of my mods broke.

Mobius Thank you, enjoy!

Looks sooo satisfying, gonna have fun with this!

add creaper ahh man pattern 

Marlim Thank you 

This looks wonderful!

OmegaHaxors Check this out