Vinconomy

I like the gacha stand very much. We're using it currently as slot machine for snacks.
There is just one issue with it... Or two.
First, it seems like the gacha ball content does not apply the "StallPerishRate" from the config.
And second; Is there a way to see if food within a gatcha ball is rotten? Like... Before you buy it?

Ket Do you have any errors in your logs? There was a previous issue with the Russian translation I posted about right before yours that I just fixed, but it was 3, 4 and not 2,3... There is also a known issue with some people using a mod to add item descriptions and change the names that can trigger a bug within Vintage Story itself when you add quotation marks to it.

Spanish localization: es-es.json

Is the Ledger supposed to have information in it beyond {0}x {1} sold for {2}x {3}? Like, item names or anything? Because I am not sure how it is meant to be interpreted otherwise?

I fixed that previously, but seems I forgot to fix that same entry in the russian lang file. Will get to it after work today.

Should read "{0}x {1} sold for {2}x {3}"

Hi! Awesome mod! I'm a bit dumb to understand the shop ledger entry. Could you please explain its purpose or maybe I set it up wrong, I am not so sure. What I see is something like this:
<player_name>:

{0}x{1} sold for {3}x{4}

And they keep repeating, same entry just different player names, for all months. It's not possible since I know I sell different stuff in my shop.

DilanRona - It works fine. Check your logs to see if you have a mod conflict preventing Vinconomy from starting up as that would be the only thing that could be causing issues.

Viconomy version 0.3.4 doesnt seem to work on Vintage Story 1.19.8. Cannot craft any of the viconomy items, Does not show existing blocks placed (only shows ? blocks). Wanted to recreate them but nothing is even listed in creative.

Tried downgrading to 0.3.2, same problem. Had to downgrade back down to 0.2.5 for the mod to start working properly again. Will upgrade again as soon as the 0.3.x series is working properly.

https://github.com/AImli-oi/Vintage-Story-MOD-Chinese-localization/blob/main/vinconomy_0.3.4

https://github.com/AImli-oi/Vintage-Story-MOD-Chinese-localization/blob/main/vinconomy_0.3.3

Chinese localization

Hi! I'm getting an error on my server when I try to interact with anything inside of the UI for the Shop Sculpture Stall. I'm using version 0.3.3 on game version 1.19.8

These are both errors, when trying to set shop ownership, and when trying to put an item inside: https://pastebin.com/sTZKkq2n

Also, when a customer tried to interact with the Shop Sculpture Stall, they'd see the owner's menu, and get kicked out of the server when trying to interact with anything, getting an error that says "Nice try, but that wasn't yours."

Thank you for any help you could provide. Also, thank you so much for this mod, it's now an essential part of our experience with the game. :D 

Aimli - Ah. Forgot about the BlockEntities passing in the dialog titles. Will get those tonight for you.

Aimli - Swapped everything over to pull from the Lang files. If you wind up translating the keys, feel free to send me the JSON file and Ill get added to the mod

ok, no problem, just was weird seeing it is all.

still a great mod!

SoulReaperz - A debug message I clearly forgot to remove. Can ignore it for now. Its related to the new Discord integration I added in 3.2

SeveredSkullz

not sure whats going on but never had this before

20.9.2024 22:10:47 [Server Event] Offthread save of savegame done.
20.9.2024 22:10:57 [Server Chat] [vinconomy] Update HTTP Called with 0 entries
20.9.2024 22:11:07 [Server Chat] [vinconomy] Update HTTP Called with 0 entries
20.9.2024 22:11:17 [Server Chat] [vinconomy] Update HTTP Called with 0 entries
20.9.2024 22:11:27 [Server Chat] [vinconomy] Update HTTP Called with 0 entries
20.9.2024 22:11:37 [Server Chat] [vinconomy] Update HTTP Called with 0 entries
20.9.2024 22:11:47 [Server Chat] [vinconomy] Update HTTP Called with 0 entries
20.9.2024 22:11:57 [Server Chat] [vinconomy] Update HTTP Called with 0 entries
20.9.2024 22:12:07 [Server Chat] [vinconomy] Update HTTP Called with 0 entries
20.9.2024 22:12:17 [Server Chat] [vinconomy] Update HTTP Called with 0 entries
20.9.2024 22:12:27 [Server Chat] [vinconomy] Update HTTP Called with 0 entries
20.9.2024 22:12:37 [Server Chat] [vinconomy] Update HTTP Called with 0 entries

i just updated to the latest version and now the server console is getting filled up with this message

the console never had this pop in before this update

Aimli - Gotcha! Will see what I can do for ya to get that into a language file. My only concern is since most of vintage story's GUI doesnt really support reactive components, I can't guarantee that the text will fit nicely in all the labels.

我必须花很多时间在源代码中寻找文本并翻译它，如果你能将它们链接到 lang 就好了！

这样即使你更新了 Mod，它也不会使我的翻译无效！

https://www.helloimg.com/i/2024/09/19/66ec0893621e3.png

I mean, there's a lot of UI text in your mod that is untranslatable in lang

yeah it was 3.0. I installed the newest version now

Aimli - I only speak English. If you would like to contribute to any translations, by all means send them my way and I will get them implemented.

Please do a good i18n, thanks!

Origin_Alpha_43 - Not sure if you are on 2.8, or 3.0+ yet, but I can confirm there was a problem in 3.0 due to the new changes. Should be fixed in the update I just pushed moments ago.

/setowner doesn't seem to work
Been trying everything. increase/lower every XYZ coordinates, the blocks just dont seem to be recognized by the command.
is there something i'm missing?

Aimli - It isnt turned on, as it is always enabled by default. Each stall/register gets its owner from whomever first placed it down. Only the owner can add/take items from it, or break the block. This means that even in unclaimed land, other players will not be able to steal items from your stalls or registers. Additionally, if your shop *is* in a land claimed area, it gives permission for other players to use it without having to give "Use" permissions for the claim to the whole server in order to make any sales.

Very good mod
But “Protection System - Protect your goods without taking up land around your store. Built in!” How is it turned on?

xXx_Ape_xXx - I removed the crafting recipe ages ago in favor of the clothing stalls, which support Helmets and other wearables. Kept it in for backwards compatability reasons. Never really saw a reason to bring them back.

Also apologies for the long delay. I have been away for a while.

How do you create the helmet stands? There's no recipe for them as far as I can see, can't find anything in the handbook either 😬

Teewi

do you have the register filled with items?

if you do when players are trying to buy from a stall, the money has nowhere to go and thus they cant buy

if you are tryin to make the shop an admin shop, you do not need to link the stalls to the register, as an admin shop, with no register selected, the money yeets itself gone

if you link a register as an admin shop, then the money goes into the register again and will need to be cleaned out regularly

SeveredSkullz

its the Deco storage chests from qpchisel  the deco storage vessel, deco chest, deco chest high capacity

that are invisible in the shop stalls
they still are sellable but just invisible

they were visible before the update, its just a minor bug not a big issue

helmet stands still dont appear to have a crafting recipe, not a huge issue, im just providing the copper versions to the players in my world for the time being so they can at least play around with them lol

Ive fixed the Tool Racks, but I am unable to replicate the problem with the Storage Vessles - and in fact that was one of the very things that this patch fixed. Before, they all rendered the "Cracked" variant and didnt display the right version.

Working on fixing the Sculpture Pad GUI issue you mentioned last night as we speak.

[img]

SeveredSkullz

ok first thing in this update, not a big issue just a image bug i guess
tool racks for the shop arnt reskining to the correct wood textures they are remaining default brown

ill edit this for any other things i find as i transfer from old to new\

storage vessals in the shop crate does not appear in the slots visually on the ground(more specifically the decorative storage vessal, chest, chest high capacity) dont know about the others at this moment

when world editing and exporting a shop then importing it back in
the shop shelf, helmet stand, register, weapon rack comes in as ? skins and without their items on them
the mats and double mats and crates work fine(everything came in as was with their skins and items and prices), the clothing stand and tool racks came in but i didnt have anything in them
this is the new blocks placed then copied and pasted in another location

on the shop mats at the very least just found out the 5x buy option, the shift crouch, doesnt seem to work

SoulReaperz - It blows my mind that that issue has been present for about 7 months according to Git, and I am just now getting a report about it. Needless to say you should not be getting the *Owner*'s menu when you dont own said stall. The Anti-cheat is firing off because they are attempting to modify stuff in the menu, take out items, etc. - and rightfully so. Ive been doing bug fixes all day and its now past midnight. Dont have any more time for now to address the problem, but I should have a fix in soon.

SeveredSkullz

Im going to say keep up the good work on this mod
its been great for my server so far, just a few minor bug/issues as youve already seen me post and have replied to
we'll see what all this update holds for us tomorrow when i apply the update to my server!!!

again Keep up the good work!!!

SeveredSkullz

The Sculpture Stall while on server in multiplayer
for me as the owner of the server it works perfectly fine 100% of the time
but for the clients, players of the server that arnt the owner
they crash 100% of the time when trying to use the stall or crouch buy the chiseled item from the stall
even when the stall is empty with nothing in it they still crash when interacting with it

there hasnt been any actual crash logs generated that i know of, but it just completely closes their game

ok i found this in the logs on the stall
21.7.2024 03:36:33 [Audit] Client (playername) got removed: 'Nice try, but that wasn't yours. (Tried to access Stall they didn't own)' ()

so far thats the only thing we came across thats removing clients

also the Shop Helmet Stand doesnt have any crafting recipes for any of its varients


an update came out shortly after i posted this

will test the new update tomorrow to find anything new and to see if this is still an issue

I have a problem with the Gacha Ball Loader - once placed, it can't be broken. I get a chat message "You do not own this.", but am still able to open the machine's operation window.

EDIT: This applies only to the Gacha Loader. The Gacha Stall can be broken normally.

Can you let me know what error message they recieve? What items are you trying to sell, what currency are you using, etc.? Can only speculate, otherwise.

Heya!
I've set up a shop and a register but others are unable to purchase from my shop despite me ticking all the right boxes and adding the currency, etc. The stalls are linked to the register and visa versa. Have you encountered this before? Is there a fix? C:

SoulReaperz - Apologies, Had typed out a response earlier today but then got pulled into a discord call with GreenM4N4 and lost the text here, then forgot.

There are a few ways you can handle this. First is to simply fill up the slots accordingly - If you want Common, Uncommon, and Rare, you can fill 3 slots with "Common" gacha balls, 2 with "Uncommon" and 1 with "Rare. That should give you a 50% / 32% / 16% split. The trick here is that you dont need to have the all of one type in 1 slot. For instance I could put all "Commons" in every slot but 1, which would give me a 88% / 11% split.

If this is not granular enough, you can tick the "Use Total Count Randomizer" checkbox and it will instead go from Slot-based chances to Item-Count-based chances. Meaning if you wanted to have a 1% chance in winning an item, you need to have a 99:1 ratio of items. The only downside to this implementation is that the winnings percentage is going to change based on the amount of items that exist in the stall - so if a player purchased 50 of them, its now a 49:1 ratio, leaving the chance of winning that 1 rare item at 2% instead of 1%. Statistically speaking, this follows the rules of probability and I made a compromise here instead of explicitly being able to set the winning rate.

The original use case for this was from a player simply wanted a gumball-like machine where they could sell candy and wanted a basic way to get a randomized output. I took the liberty of expanding this and turned it into the Gacha stall simply because it was "close enough" of an implementation to give you guys a bit more freedom and creative liberty. The end goal isnt to give you guys tools to implement outright gambling on servers, nor do I want Vinconomy to become a means of selling "loot boxes" or other pay-to-win mechanisms on multiplayer servers. Im therefore hesitant to implement that level of control because thats not the underlying intent of this stall type.

@SeveredSkullz

speaking of Gacha
would be nice to be able to have adjustments on each slots percentage chance so we could actually make true common, uncommon, rare, and very rare Gacha chances when playing the Gacha machine

kinda sucks right now when you fill all the slots and its is equally divided up into 11% each instead of being able to adjust each slots percentage chances to make some items more common when playing and some more rare

It is not possible currently with crates, BUT you can abuse use the Gacha Balls to accomplish the same task

Also i thought about a suggestion, in our server sometimes players need a lot of recources, like sticks or grass, clay, etc.. So what if we had a stall for crates? Like i fill a crate with a few thousand sticks and could sell the whole crate? I dont know if thats possible, but would be hell of a cool functionality, or selling barrels of wine or beer :)) P.S. we can move crates with carry on functionality, i think its a mod, so i dint know if its even a possibility to add to the mod. Just a suggestion to consider :))

If you can send them to me in the Discord Thread I can take a look

Hey, I am a Mod on Sanctuary where EphKa's error is happening.

We have tried replacing registers and it looks like it is just creating a new shop ID everytime. Its almost like when the server restarts it is losing the mapping from register to shop ID. I can provide the DB and logs.

I assume you are on the most recent version given you saw my error message. Have your players made a new register, or are they just breaking and replacing the same register prior to the June 6th fix? If they made a new one and its still erroring out like that, I would certainly like to take a closer look at it via the logs and DB. If its the latter and they are re-using the same stall, then replacing it with a newly crafted Register should fix the issue. They store a bunch of IDs internally which are persisted each time you break/place them, and once that ID is used it is going to continue to bug out. The only way to fix it at that point is to craft a new Register and throw the old one away.

You see, one of the players has the shop register inside the shop, like 5 blocks away, and the disconnection between shops and stalls happen after server restart, i think thats the problem.

EphKa That is the INTENDED implementation in that it will only sell you things if the item matches exactly. And you're likely right in that it worked previously - I had to flip it because people were trying to Buy food from other players by setting the currency to the item they wish to buy and "sell" the rusty gears as compensation. Problem was then that it was too strict for food since the attributes change the second you harvest it and the "freshness" varibles would never be identical. Now that I've flipped the logic and told it to ignore the Source, its now too lax on things I actually want it to check. I cant tell you how many times this particular check has bit me trying to rely on the game's code to check these things. I'll have to write my own custom implementation to solve this problem, it seems.

Side note: "we are resseting our shops on every server restart because of unloaded chunk bug"
The solution here is just dont put your Registers 100+ blocks away from the shops. As long as they are nearby, this issue shouldnt occur.

Yes, maybe it was even tested on vinconomy now that i think about it and it worked previously, my bad, it was not canmarket. Yeah i bought with unsigned parchment some goods where the price is a signed parchment. Is it possible to make the deal only if the price is met exactly how it is? idk if thats possible

tRead - The amount on the right is simply the stock used to fufil purchases. If you are selling 8 peaches, you only need to have atleast 8 of them in any number of slots. You could have 1 Peach in 8 seperate slots, or 32 in a single slot - the arrangement does not mater, only that the total quantity is greater than or equal to the amount you are selling at a time.

EphKa - Just to make sure I am understanding the need / problem correctly: You are using signed parchments as a form of currency. When you put this item in the currency slot, people are able to buy your items with an unsigned / plain parchment?

Hello, we had created a currency in our multiplayer server called Merits, which are parchments. So we had our economy running on canmarket mod, and the mod differentiated between a blank parchment and a signed parchment, but with vinconomy introduced to the server, anyone can counterfeit Merits to buy stuff from our shops, i was wondering if you could add differentiation between a parchment and a signed paper?

Also thank you for your hard work, we are resseting our shops on every server restart because of unloaded chunk bug, but its allright, we will wait for the fix. So thank you for the things you do, you bring us much joy in our roleplay :)) 

When stocking a shop, I understand that the part on the left is important for quantity: example 2 rusty gears for 8 peaches.  But what's the square area on the right for?  Simply inventory space for stacks of items to sell?  Don't need to separate peaches into stacks of 8?
So, "36 total stacks of goods" is the maximum I can fit at once; then refill when the quantity drops?

*Does it matter how many items are placed in a slot for an Admin shop?*

Btw, I recommend adding a brief description of the Teller comparing with the function of the Register.

SiiMeR - Is this with a brand new register or a bugged out register prior to the fix? I am unable to replicate the problem.

I have a problem on my server that players are somehow able to craft registers that make them crash upon placing them. After logging in again, a server-owned cash register will have been placed, with no possibility of removing it (and you will still have the cash register on hand). 

I thought that maybe the version update could fix it, but the error message has changed.

An exception is being thrown on the latest version 

Exception: Value must be set.
at Microsoft.Data.Sqlite.SqliteParameter.Bind(sqlite3_stmt stmt)
at Microsoft.Data.Sqlite.SqliteParameterCollection.Bind(sqlite3_stmt stmt)
at Microsoft.Data.Sqlite.SqliteCommand.GetStatements(Stopwatch timer)+MoveNext()
at Microsoft.Data.Sqlite.SqliteDataReader.NextResult()
at Microsoft.Data.Sqlite.SqliteCommand.ExecuteReader(CommandBehavior behavior)
at Microsoft.Data.Sqlite.SqliteCommand.ExecuteScalar()
at Viconomy.Database.ViconDatabase.AddShop(ShopRegistration shop)
at Viconomy.Registry.ShopRegistry.AddShop(String owner, String ownerName, String name, BlockPos pos)
at Viconomy.ViconomyCoreSystem.AddShop(String owner, String ownerName, String name, BlockPos pos)
at Viconomy.BlockEntities.BEVRegister.UpdateShop(String Owner, String OwnerName, Int32 ID, String Name)
at Viconomy.BlockTypes.BlockVRegister.DoPlaceBlock(IWorldAccessor world, IPlayer byPlayer, BlockSelection blockSel, ItemStack byItemStack)
at Vintagestory.GameContent.BlockBehaviorHorizontalOrientable.TryPlaceBlock(IWorldAccessor world, IPlayer byPlayer, ItemStack itemstack, BlockSelection blockSel, EnumHandling& handling, String& failureCode) in VSSurvivalMod\BlockBehavior\BehaviorHorizontalOrientable.cs:line 55
at Vintagestory.API.Common.Block.TryPlaceBlock(IWorldAccessor world, IPlayer byPlayer, ItemStack itemstack, BlockSelection blockSel, String& failureCode) in VintagestoryApi\Common\Collectible\Block\Block.cs:line 836
at Viconomy.BlockTypes.BlockVRegister.TryPlaceBlock(IWorldAccessor world, IPlayer byPlayer, ItemStack itemstack, BlockSelection blockSel, String& failureCode)
at Vintagestory.Server.ServerSystemBlockSimulation.TryModifyBlockInWorld(ServerPlayer player, Packet_ClientBlockPlaceOrBreak cmd) in VintagestoryLib\Server\Systems\World\BlockSimulation.cs:line 575
at Vintagestory.Server.ServerSystemBlockSimulation.HandleBlockPlaceOrBreak(Packet_Client packet, ConnectedClient client) in VintagestoryLib\Server\Systems\World\BlockSimulation.cs:line 346
at Vintagestory.Server.ServerMain.ProcessNetMessage(NetIncomingMessage msg, NetServer mainSocket) in VintagestoryLib\Server\ServerMainNetworking.cs:line 138

On the previous version, the exception was:

Exception: Tried to update a non-existant shop at Viconomy.Registry.ShopRegistry.UpdateShop(Int32 id, String name, BlockPos pos) at Viconomy.ViconomyCoreSystem.UpdateShop(String owner, Int32 iD, String name, BlockPos pos) at Viconomy.BlockEntities.BEVRegister.UpdateShop(String Owner, String OwnerName, Int32 ID, String Name) at Viconomy.BlockTypes.BlockVRegister.DoPlaceBlock(IWorldAccessor world, IPlayer byPlayer, BlockSelection blockSel, ItemStack byItemStack) at Vintagestory.GameContent.BlockBehaviorHorizontalOrientable.TryPlaceBlock(IWorldAccessor world, IPlayer byPlayer, ItemStack itemstack, BlockSelection blockSel, EnumHandling& handling, String& failureCode) in VSSurvivalMod\BlockBehavior\BehaviorHorizontalOrientable.cs:line 43 at Vintagestory.API.Common.Block.TryPlaceBlock(IWorldAccessor world, IPlayer byPlayer, ItemStack itemstack, BlockSelection blockSel, String& failureCode) in VintagestoryApi\Common\Collectible\Block\Block.cs:line 836 at Viconomy.BlockTypes.BlockVRegister.TryPlaceBlock(IWorldAccessor world, IPlayer byPlayer, ItemStack itemstack, BlockSelection blockSel, String& failureCode) at Vintagestory.Server.ServerSystemBlockSimulation.TryModifyBlockInWorld(ServerPlayer player, Packet_ClientBlockPlaceOrBreak cmd) in VintagestoryLib\Server\Systems\World\BlockSimulation.cs:line 575 at Vintagestory.Server.ServerSystemBlockSimulation.HandleBlockPlaceOrBreak(Packet_Client packet, ConnectedClient client) in VintagestoryLib\Server\Systems\World\BlockSimulation.cs:line 346 at Vintagestory.Server.ServerMain.ProcessNetMessage(NetIncomingMessage msg, NetServer mainSocket) in VintagestoryLib\Server\ServerMainNetworking.cs:line 138

Suggestion/Request:
Could we get a register that is more designed for buybacks? for example if you setup a shop for buying stone, your reister is going to fill up rather quickly. So maybe a register with a slot for coins/money and a slot for inventory, that coudl also be conected to a hopper? (so coins don't fall out due to the hopper) - to make for larger bulk sales a bit more eaiser?

Following what Mcquiggles said; maybe something like how the current chisled things are sold could work for bundling/mixing sale items; (infact that might be possible now? might need to test that, but the bundles wouldn't be random)

a gumball/slotmachine for random prizes would be a fun idea to include as well.

McSquiggles

I am making a Candy Shop in the Rouge House Server and I'm trying to make "mystery boxes". Which is a random assortment of candies in a wattle basket, bark basket, etc... There's no way as of now to be able to put a basket in a slot to sell (on shelf, crate, etc...) but I am curious if there's possibly a way to do it or make it work? If not it might be a good idea to be able to create "foil bags/baskets". I was thinking if there was a shop barrel, where you could put a few different items in it (9 slots?), but it would give the player a random slot from that barrel for a set price. Where all the random items in that barrel would have the same price. Doesn't have to be a barrel but that's just an example.

I love this amazing mod btw, I've really enjoyed being able to walk around to others shops and buy products! I can't wait to see the next updates and new ideas coming out of this mod.

-Julia

Could we possibly have the ability to craft the shops with plain cloth? I actually like the natural white color over the dyed white.

https://prnt.sc/Q_iMZ0kVE4ix

@SeveredSkullz It is Expanded Foods' syrup covered fruit breads (any it would seem as I had a multitude of different fruit breads with different swirls), they would all become just regular base game breads on the Acacia shelves. I've not tested with other shelves. Thank you for the recent fix with the armour!

Quiche I am unable to replicate the problem with the food. I even tested it with Screwy over in the discord's mod page. Is there a specific type of Cooked food that does not show up? I am able to replicate the problem with the Armor stands and working on a fix.

Strange things happening with new update. Armour helms on the armour stands will show up on the floor and all EF bread becomes a base game flax loaf with no pretty swirls showing. Crocks do show up larger, but cooking pot and bowls do not. Thanks for all your hard work, I did have to do a rollback to the previous 2.5 and things were working peachy again.

guess you got a point. would have prefered the teller machine, but can settle for one of the other stalls

DilanRona - Then dont use the ATM block for that - just use a normal stall and "sell" the currency youre trying to convert. ATMs are exactly what they say on the tin. They convert currency. If I give you a dollar for 4 quarters, I should be able to turn those 4 quarters back into a dollar - they are equivalent.

Screwy - I will try to take a look in the next few days if I get some free time. Will also try to see if I can figure out the expanded food issue too, though I dont use that mod. From what I've been told the food rendering is very complicated and annoying to work with - so no promises Ill be able to fix that in the same timeframe.

Books used to show up on shop mats. At least the unwritten ones, in previous versions of this mod. We just realized on our server, that this isn't the case anymore. I hope you can fix that soon, because we try to establish selling informations about resources, written in books.

I am referring specifically to the Shop Teller Machine. They can go both ways (ie reverse trade). There is currently 6 set up on my server, but I need to have 1 or 2 set up to only go one way. In otherwords I want to disable reverse trade on specific Shop Teller Machines.

All trades are only "One Way" - I dont understand what you mean? You have a Price and a Product. You give the stall the Price, and recieve the Product. You cannot give up the Product and recieve the Price item.

Have a request, is it possible to have the trades go only one way? There are some trades I need to set up for an admin shop but it should only be one way.

I will add it to my "Todo" list Keito

Hello, this is a silly request but would it be possible to increase the size of pottery items on the shelves and mats? Right now, bowls and crocks for example are comically small, but I think they would fit at essentially actual size. "What are these... pottery for ants?" 

Some food items from the Expanded Foods mod still don't render in stalls. While trying to reproduce the bug, I recognized that this is only the case, if the items are made in survival. Maybe this is a usefull information. The equivalents that you get from creative mode will work perfectly fine. For testin we used sushi and breaded foods.

The issue should be fixed.

Norbix

SeveredSkullz

I am experiencing the same issue with Sculpture Stalls.  Set up a register with a store name saved, currency in register.  Placed a Sculpture Stall, attached it to the created store name, placed in items, disabled unused slots, assigned a price.  Everytime you go to purchase, "This stall is not registered with a  shop yet.  Unable to make a purchase."  See imgur album for reference imgur.com/a/uZOSyaW

Update: Any attempt to name sculptures within the stall does not work.  It doesn't save.  Also, the sculpture stalls are remembering every shop I've ever created, instead of what is "active".  Every other stall type lists exclusively active shop registers, the sculpture stalls are listing EVERYTHING.

SeveredSkullz

It worked! Thank you!

Hydromancerx - You must have atleast enough for a sale - Setting it as admin only prevents it from removing the stock from the stall. It doesnt disable all the other checks. Since you set the amount to give to 10, but only have 1 in the stall, it fails. Either add more to the stall, or set the amount per sale to 1, then buy a few until you have 10.

SeveredSkullz

So I made Produce crate and set it to sell flax fibers for a rusty gear. But when i click to buy it says You purchaced 0x Flax for 0x Rusty Gear. Later i added a cash regester and set the shop up. But still had the same result.

Hydromancerx - it is absolutely possible in Single Player. I cannot assist without further information

Norbix - Any luck reproducing the problem?

Is this just not possible in single player? I tried to set up an admin shop to buy from the infinate goods but it just gave 0 for 0. :(

Hey, we put a stand for the sculpture, set up a 2x2 sculpture and assigned it to a store, and when we try to buy, we get a message that the stand is not assigned to any store. Are we doing something wrong or is it a bug? I will try to reproduce it more precisely

I would like to suggest some sort of whitelist for the config file to let admins specify the items that would count as currency. As of now it's "gear-rusty", in our servers case i would also like to add "gear-rusty-gold" as an possible currency. These are coins (re-skinned rusty gears) that the players can produce themselves.

Kara - theres only so many combinations I can add to a given entity. Shift and Control are the only modifiers allowed, and both are taken. I simply do not have any more combinations available to me in order to do so. You can take control of the shop / stall with the "setowner" command which should be a suitable workaround - and then set the owner back to the original player once you are done.

SeveredSkullz may you please add the ability for admins to open players shops/register? duped items hidden in a register, i had to break it, to get it out. 

Bug: ice in a shop, wont render the blocks behind them allowing players to use it as a xray for seeing caves. 

Morning Fellas - Just pushed Version 1.9 for VS 1.18.x, and Version 2.3 for VS 1.19.x which should fix the issue.

As a side note, I know some people are still on 1.18 and do not wish to update. However, it is starting to get troublesome to reinstall older versions of the game, blow away my entire solution, rebuild the solution, fix the dependencies so they point to the older version of the game, recompile, and then undo all of that to go back to 1.19. With that said, this is likely my last update for 1.18.x

Hey fellas! Just got back home from the vacation. Stayed a bit longer than we had anticipated. Our son got to go to the beach for the first time and he was loving it so much we decided to stay an extra few days. As soon as we are unpacked and settled in, I will take a look at the issues you guys mentioned. Should have a fix for it within the next few days.

SeveredSkullz
The bug he's talking morlanius 

about is in earlier versions of the mod (v0.1.8 too). It's pretty serious.

It's a good thing there are nice testers out there who were able to detect it :3 

SeveredSkullz

Bug: Making the quantity a negative number of gears whilst having at least 1 gear in your hand will give you gears as a positive number. The gears are not taken from the register and no items are exachnged, basically a gear dupe. The register is right next to the shop. 

Using version 0.2.2 on server version 1.19.3

SeveredSkullz Thats fine, you have a good vacation and try not to stress about a silly game =D. have a lovly vacation =D. ^v^

Kara - I am currently on vacation with my family and dont have access to my PC for a while. When I return I will be happy to take a look into it. The only thing that comes to mind is if the register is in an unloaded chunk when the sale is made. I dont know how far away you are considering "near" in this case, but if we are talking hundreds of blocks that is likely the cause. Currently I dont have any code to try and load the chunks before a sale is made. Vintage Story has a way to Force-load chunks, but no way to *UN*force-load the chunk. It was a problem I have been looking around for a solution for a while to no avail, and as such I did not want to force-load hundreds of chunks for all the registers and stalls, likely reducing performance on all of your servers.

I have been getting reports from my players that the shops have randomly stopped working. us breaking the shop and them placing a new one needs to fix the issue, although i dont have any crash reports or errors to go off of, just reports from players D=. ill report if i get more into from the. 

It seems the Registers seem to break when not placed near the shalls selling items. 

This make the stalls through errors like they are out of stock or unregistered/not set up correctly

Issue should be fixed now. Added an additional failsafe in order to prevent that from messing up the GUI even if it doesnt get cleared up in the future for whatever reason.

I also fixed the Mod's Game Dependencies, so you shouldnt see that "Failed parsing version string '1.19.0-rc.*'" error anymore on 19.0. Im aware Tyron fixed this bug in 19.1 but oh well :D

WickedSchnitzel / Kara - Will try and take a look at this tonight. Thanks for letting me know. Didnt seem to be an issue in the release candidate version, so Ill look into what changed.

seems to be buggy in 1.19.1. -shop wont get displayed in the drop down menu until you relog. -old shops will display even if the cash registers have been destroyed

Not sure if its a bug or What, but Old "shops" are not being removed from the list. i am also unable to create New shops after pressing save. 

WickedSchnitzel - That was the format for the Release Candidates, which is what the current 2.0 version was built for. You can safely ignore this warning - It wont cause any errors.

[Warning] [vinconomy] Dependency 'game': Failed parsing version string '1.19.0-rc.*' at index 10: Unexpected character '*' in PRE_RELEASE identifier (best guess: 1.19.0-rc)

if you ddi add automatic conversion you could also include an ATM already setup to exchange between those rates as well

Alatyr I do not have any plans on adding support for 2 different types of currency, as it does not make any sense to in my opinion. Take the US Dollar - you have whole and partial dollar amounts. If something cost me $1.50, I do not HAVE to have 1 USD and 2 Quarters. I can have 6 Quarters instead, or 15 Dimes. You can set the price to the equivalent of what it would cost in Rusty Gears, and have a Temporal Gear trade in the ATM.

As an example, say I wanted to have a stack of Turnips at 5 Rusty Gears and 1 Temporal Gear. I could have 1 Temporal Gear = 10 Rusty Gears, and thus would set the price at 15 Rusty Gears. Players then could use either 15 Rusty Gears, or trade their Temporal Gear at the ATM for 10 Rusty Gears, and then buy the item.

I have been toying with the idea of being able to automatically exchange currencies - but I am worried about players potentially trading an item they did not intend due to the automatic nature of things. Will need to come up with a solution to that before I actually implement it.

If you can think of a reason that I absolutely must support 2 different types of currencies, please let me know and I will look into it. As the code is written, it would take a significant amount of work to re-write the entire logic for all the stalls in order to be able to support this - almost a complete rewrite. I am not going to be making that effort unless there is an absolute *need* for it.

Is it possible to add the ability to set a price for 2 items? For example, set the price equal to 1 temporal gear and 1 Rusty, for example.

Nice thank you very much I was just waiting for it :-)

I have uploaded the 0.2.0 Release for 1.19-Pre... Keep in mind this new version is NOT COMPATIBLE with older versions of the mod. The save system was migrated over to a new SQLite database and any attempt to use shops registered under the old system WILL NOT WORK.

Hmm my idea was Like having a Register what Have like a tube. Or something simmilar What could go down into a Storage area, I have trouble to always empty the Register out when my Friend sells his stones. But thank you for hearing me out.

TimSithis Im open to ideas, but thats essentially what the Register already does - How would it be any different from a mechanics perspective? The only difference is you have a model that looks like a safe instead of a cash register. I do have plans for a sort of "treasury" when I finally get to the Cities / Claims aspect of things, but that wouldnt be a part of Vinconomy.

Hmmm do you think you will someday make it possible that Your Currentcy..or Let's say the money you get can be put into something Like a HUGE Safe for keeping and storage?

Honestly a fantastic mod to build a functional/aesthetically-pleasing shop with. I love it!

Screwy -   It is highly unlikely it will be in the next update, as I have one thats been in the works and I have been trying to get finished for a few weeks now. IRL issues keep getting in the way and preventing me to finish the final features (If you're curious, check the Mod Page on discord). As for the food - you are right, it is intentional that the items must match exactly - especially for food. I did not want situations where players might abuse the stalls with only 1 item that was "fresh" and the rest borderline rotting / rotten. The UI is going to show the first item that is not an empty slot for simplicity's sake, and that fact could be abused. Internally, I am doing a simple "Satisfies" check which is entirely built into VS - meaning it's not my code. In order to do what you want I would have to roll my own - which is totally doable, but it might just take some time with everything going on right now. I can certainly add it to the list, and perhaps just put the replacement implementation behind a configuration variable to use exact matching or approxomite. Another solution is I can just average out the decay rate on all the item stacks when you try to add a new stack. I will play around with it and see what feels right.

As for your message about it not showing item info in the customer UI, what exactly do you mean? It should be showing you a passive item slot containing the first non-empty item for that slot. I have not heard of any issue with this from anyone else, and I have not seen it in my own testing. If possible, could you please provide a screenshot of the problem either here or up on discord to demonstrate what you mean?

SeveredSkullz I'd like to thank you so much for this awesome mod! We use it on our upcoming German server and it enables us to manage almost every aspect of our economy.

But one thing is a bit... annoying. I understand that it has to be the exact same item on all 9 slots of a stall. But this makes it almost impossible to get more than one food item in there.
Is there any way this could be fixed in the next update? Maybe my either ignoring the decay rate while checking if it is the same item, or by some tolerance value for this variable.
And there is no item info in the customer UI. Is this intended? Can we have a config bool for that?

WickedSchnitzel - You shouldnt need World Edit simply to remove the shop. If you are in Creative Mode it will bypass the protection and allow you to remove it. That was a request by AngelLord via Discord that I added in 0.1.4. Im also sitting on a change that allows players to use shops within claims so you will no longer have to use /allowuseeveryone that was requested by him as well up on discord. They were using Claims as a sort of "rental" property and didn't want to have to manage adding/removing everyone all the time. Im also in the process of refactoring the code to allow sales to be conducted without having to have all the items in your hand, which is preventing me from pushing said change right now. I hope to have time this weekend to finish up the implementation and get that out to you guys soon.

But yes, the stalls / registers have protections in place in that they do not need to be within claimed land to be protected. As you saw, it wont allow anyone to break the shop unless they are the owner, or an Admin currently in Creative Mode (You HAVE to be in creative mode). If a player has left the server, and you believe they are not coming back, you can also use the "/vicon setowner [player] [x] [y] [z]" command for the stall/register in question to take over ownership of it instead of outright removing it.

paintmoses - Assisted via Discord :)

How to you find the commands for your mod, I am trying to make shops I can use and edit, if thats a possibility?

Thanks in advance.

Wow, that's great. Thank you very much SeveredSkullz!

I'm going to try it :-)

fipil - Just pushed 0.1.4 which adds the features you requested. Still dont have much free time with all the chaos, but its still next on my "todo" list for ATMs.

Thank you SeveredSkullz!
Your solution would be fine. Another approach could be introducing of some admin item so user should hold it to open the admin view. But I understand that this would unpleseantly change the existing workflow to which users are already used to.

I noticed the ATM block in the future plans, so I'm looking forward to it. :-) Hope that the ATM design will look medieval, we build a medieval world so some modern ATM machine with a display would be a little bit problem for us :-D.

I'd be also very nice if your mod could work with our smaller denomination Copper wheels. For example user wants to buy a carrot priced 4 copper gears. Then he'll pay 1 rusty gear and the shop returns him a change: 6 copper gears. 

Fantastic mod! It seems that sometimes though, it will say a player does not have enough of a currency item in hand when in fact they do. The shop is well stocked too, so I cannot see why this would happen. It seems to happen randomly, and relogging does not solve. 

fipil It is not possible to check for an arbitrary key as a Hotkey, unfortunately. While I cannot add any more hotkeys, I can check if the item in your hand is the currency item while you are sneaking to allow you to purchase items from your own stall. I will add this to my "To Do" list along with the ability to remove other players stalls/registers as an admin someone else requested via Discord. Should be able to get to it in the next day or two, provided I get a break from the IRL chaos.

Also, please note that an ATM block explictly designed for currency conversion is on my Future Plans / Roadmap in the mod description. Eventually, you won't need a dedicated shop to do this. I just need to get the free time back to be able to implement it. 🙃

Hi SeveredSkullz

I love your mod. I see only one big problem: As an owner of the shop, I cannot USE the shop. You can ask why want I use my own shop? The reasons are the following:

• I want simply test my shop, if it works and is configured properly.
• We have two kind of money on our server, the vanilla rusty gears and the copper gears, provided by our mod, which we use as change: 1 rusty gear = 10 copper gears. I created an admin shop, where player can change 1 rusty gear by 10 copper gears and also to change 10 copper gears to 1 rusty gear. Problem is that I cannot USE the shop. I'm an admin but also a player which want to use the shop as an ordinary player.

So please, would it be possible to change behaviour so the shop configuration will open only by using some hotkey together with a mouse click and if player does not use the hotkey, the shop will act as a shop for him?

Thank you very much.

Fipil

JunidO - I'm not sure what you mean by that. If you are referring to the number of slots that is used to sell the items to other players, then no I do not have any plans on increasing that amount. I feel that 36 slots for stock is way more than enough. The whole design philosophy is for you to have a large shop if you want to sell large quantities of items. If you need more inventory slots for a given item, you can always use more than one Stall Slot. There is nothing preventing you from selling 9 stacks of Turnips in each of the 4 Stall Slots.

If that is not what you mean, I would need a bit more clarification.

A great mod, I've been waiting for it for a long time. I'm excited to see what else comes next.
Could you integrate extra storage space for things you want to buy through your shop or expand the storage space of the shop register?
Hope you understand what I mean, unfortunately I can't speak English and have to use a translator.

Hey WickedSchnitzel Dealing with some maddness IRL so havent gotten a chance to work on it since the last release.

Clothing Stand is still WIP as of right now. It works, but I dont have a crafting recipe for it yet since I'm fighting with some positioning - though I might just give up on being a perfectionist and take a "Close Enough" approach. Without going though and doing a whole slew of custom models for each clothing piece, I dont think they will ever line up correctly / not overlap.

As for the Chiseled objects, I absolutely plan on getting that working. You can still sell them, but they wont be displayed correctly currently. The only workaround right now is to open up the UI, which should render the item's icon so you can atleast get a glimpse at what it is. I am also toying with an idea of having some sort of "Multiblock" display for those creations that take up more than 1 block (like a 3x3x3 creation).

The thing is that people would like to sell chiseled objects as well, also clothing etc. Will support for these objects be added in the future? If you have problems with implementing it, maybe take a look at CAN Market's source, as it works there?
mods.vintagestory.at/canmarket

Wow! What a brilliant mod! Looks like the shopping mod I was dreamed of :-). I'm going to try it! Thanks. Keep up the perfect work.

Thanks for working with Ket! We've reinstalled the new v1.1 and things seem to be working fine now. I appreciate the explanation. Keep at it and happy modding!

Thats why I said "Redownload" - While I was working with Ketamine/Horizons on Discord, I was had mistakenly changed 1.1's Zip and hadn't made a new version (Was still trying to figure out the site). At the time I think there was only like 8 people had downloaded it, so I didnt think anything of it. I assume you were one of those 8 people.

If you redownload and reinstall v1.1 and its *still* erroring out, please let me know - and preferably send me your save so I can take a look.

It happened with 0.1.1, which is the latest version SeveredSkullz

WickedSchnitzel Not sure if you are up to date or not on the mod, but this issue was already addressed below from help with Horizons. Redownload v0.1.1 and the issue should be fixed.

Run ok for a while, then crashed the whole server with

[Server Error] Exception thrown during handling event OnSaveGameLoaded: System.NullReferenceException: Object reference not set to an instance of an object.
at Viconomy.Registry.ShopRegistry.GetCount()
at Viconomy.ViconomyModSystem.OnSaveGameLoading()
at Vintagestory.Server.ServerEventManager.TriggerSaveGameLoaded() in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Server\ServerEventManager.cs:line 474

Horizons I spoke with Ketastrophe via discord and he sent me the world files from your server. I have narrowed down the root cause being an edge case where the game saved when you had no Registers placed. My clean-up code kicked in to remove the listing for that register, and ultimately the serialization of an empty Dictionary caused the value to be saved as "null" for your Player UUID. When the game then went to load your Registers, it got null instead of the Dictionary to loop through. Problem fixed - And fortunately, I can say that Fantasy Creatures (or any mod) had nothing to do with this issue.

@SeveredSkullz AHH ok alright! then i said nothing :D 

Horizons Unfortunately I am still unable to replicate the issue you are facing. I created a new world, Set up 3 different Registers, with 4 Stalls each. I then saved the game, quit to the main menu, installed Fantasy Creatures, and reloaded the game.

Thank you for your time testing for our bug!

Because you were wondering, the method used to determine Vinconomy is the issue was removing half the mods, seeing which half still had the error, and then repeating. We narrowed it down to seeing the error with only Vinconomy installed. With all other mods except Vinconomy installed, the error did not appear.

This morning we did more testing, including in singleplayer, a copy of the server, and the original server. We found that the issue seems to be linked to the save file itself. A new save does not have any issues with Vinconomy or Vinconomy with our other mods.

After further testing with a new save file, we managed to replicate the error by first installing Vinconomy, testing it in game, and then Fantasy Creatures (which was previously removed from our server), which triggered the set of errors right away. It seems that despite removing Fantasy Creatures, something about how it alters the save file does not play well with Vinconomy.

We did find an additional error in the log:

29.9.2023 08:41:11 [Server Error] Exception thrown during handling event OnSaveGameLoaded: System.NullReferenceException: Obje ct reference not set to an instance of an object. at Viconomy.Registry.ShopRegistry.GetCount() at Viconomy.ViconomyModSystem.OnSaveGameLoading() at Vintagestory.Server.ServerEventManager.TriggerSaveGameLoaded() in C:\Users\Tyron\Documents\vintagestory\game\Vintagestor yLib\Server\ServerEventManager.cs:line 474

Once again, thanks for your time. We fell in love with the mod right away and can't wait to play with it on a new save!

😁 cool so far , i found some simple issues i guess, the list from the shop does not update by itself by removing a "Shop register" and for adminshops i think would be better that the currency would deleted

I was fairly confident upon seeing the stacktrace that my mod had nothing to do with that error. To be sure though, I went and made a new world, set up a few simple shops, and started a temporal storm with "/nexttempstorm now" and did not crash. Retried on 2 additional worlds for a total of 3. Could not replicate the issue.

Im not sure what is giving you the impression that Vinconmy is at fault here, but looking at the source of RiftWeather.cs up on Github the root cause is trying to getting the next drifter to spawn. I assume you have a mod that modifies drifter spawns. This is obviously not modified by my mod - everything here is custom.

Getting fatal errors when there's a temporal storm. To our surprise, we narrowed it down to Vinconomy. Can you take a look, please?

The error:

28.9.2023 17:55:00 [Fatal] System.NullReferenceException: Object reference not set to an instance of an object.
at Vintagestory.GameContent.ModSystemRiftWeather.onServerTick(Single dt) in C:\Users\Tyron\Documents\vintagestory\game\VSSurvivalMod\Systems\Rifts\RiftWeather.cs:line 211
at Vintagestory.Common.EventManager.TriggerGameTick(Int64 ellapsedMilliseconds, IWorldAccessor world) in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Common\EventManager.cs:line 59
at Vintagestory.Server.CoreServerEventManager.TriggerGameTick(Int64 ellapsedMilliseconds, IWorldAccessor world) in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Server\ServerEventManager.cs:line 124
at Vintagestory.Server.ServerMain.Process() in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Server\ServerMain.cs:line 881

PatrickStar10 - It is for both, meaning in order for it to function at all it needs to be on both the Client and Server. It will work fine in Singleplayer, but I dont know what use it will be for you unless you enjoy buying and selling goods to yourself (Which you cannot do anyway - Stall owners will only get the Owner UI and Interactions).

Does this work in singleplayer or is it a client mod only right now?

The future plan for NPCs being able to buy sounds really nice 

pls add donation link :D this is the mod i already waited for 

This would pair well with Xel's Coinage or Zolgrim's Coinz.