Vinconomy

All trades are only "One Way" - I dont understand what you mean? You have a Price and a Product. You give the stall the Price, and recieve the Product. You cannot give up the Product and recieve the Price item.

Have a request, is it possible to have the trades go only one way? There are some trades I need to set up for an admin shop but it should only be one way.

I will add it to my "Todo" list Keito

Hello, this is a silly request but would it be possible to increase the size of pottery items on the shelves and mats? Right now, bowls and crocks for example are comically small, but I think they would fit at essentially actual size. "What are these... pottery for ants?" 

Some food items from the Expanded Foods mod still don't render in stalls. While trying to reproduce the bug, I recognized that this is only the case, if the items are made in survival. Maybe this is a usefull information. The equivalents that you get from creative mode will work perfectly fine. For testin we used sushi and breaded foods.

The issue should be fixed.

Norbix

SeveredSkullz

I am experiencing the same issue with Sculpture Stalls.  Set up a register with a store name saved, currency in register.  Placed a Sculpture Stall, attached it to the created store name, placed in items, disabled unused slots, assigned a price.  Everytime you go to purchase, "This stall is not registered with a  shop yet.  Unable to make a purchase."  See imgur album for reference imgur.com/a/uZOSyaW

Update: Any attempt to name sculptures within the stall does not work.  It doesn't save.  Also, the sculpture stalls are remembering every shop I've ever created, instead of what is "active".  Every other stall type lists exclusively active shop registers, the sculpture stalls are listing EVERYTHING.

SeveredSkullz

It worked! Thank you!

Hydromancerx - You must have atleast enough for a sale - Setting it as admin only prevents it from removing the stock from the stall. It doesnt disable all the other checks. Since you set the amount to give to 10, but only have 1 in the stall, it fails. Either add more to the stall, or set the amount per sale to 1, then buy a few until you have 10.

SeveredSkullz

So I made Produce crate and set it to sell flax fibers for a rusty gear. But when i click to buy it says You purchaced 0x Flax for 0x Rusty Gear. Later i added a cash regester and set the shop up. But still had the same result.

Hydromancerx - it is absolutely possible in Single Player. I cannot assist without further information

Norbix - Any luck reproducing the problem?

Is this just not possible in single player? I tried to set up an admin shop to buy from the infinate goods but it just gave 0 for 0. :(

Hey, we put a stand for the sculpture, set up a 2x2 sculpture and assigned it to a store, and when we try to buy, we get a message that the stand is not assigned to any store. Are we doing something wrong or is it a bug? I will try to reproduce it more precisely

I would like to suggest some sort of whitelist for the config file to let admins specify the items that would count as currency. As of now it's "gear-rusty", in our servers case i would also like to add "gear-rusty-gold" as an possible currency. These are coins (re-skinned rusty gears) that the players can produce themselves.

Kara - theres only so many combinations I can add to a given entity. Shift and Control are the only modifiers allowed, and both are taken. I simply do not have any more combinations available to me in order to do so. You can take control of the shop / stall with the "setowner" command which should be a suitable workaround - and then set the owner back to the original player once you are done.

SeveredSkullz may you please add the ability for admins to open players shops/register? duped items hidden in a register, i had to break it, to get it out. 

Bug: ice in a shop, wont render the blocks behind them allowing players to use it as a xray for seeing caves. 

Morning Fellas - Just pushed Version 1.9 for VS 1.18.x, and Version 2.3 for VS 1.19.x which should fix the issue.

As a side note, I know some people are still on 1.18 and do not wish to update. However, it is starting to get troublesome to reinstall older versions of the game, blow away my entire solution, rebuild the solution, fix the dependencies so they point to the older version of the game, recompile, and then undo all of that to go back to 1.19. With that said, this is likely my last update for 1.18.x

Hey fellas! Just got back home from the vacation. Stayed a bit longer than we had anticipated. Our son got to go to the beach for the first time and he was loving it so much we decided to stay an extra few days. As soon as we are unpacked and settled in, I will take a look at the issues you guys mentioned. Should have a fix for it within the next few days.

SeveredSkullz
The bug he's talking morlanius 

about is in earlier versions of the mod (v0.1.8 too). It's pretty serious.

It's a good thing there are nice testers out there who were able to detect it :3 

SeveredSkullz

Bug: Making the quantity a negative number of gears whilst having at least 1 gear in your hand will give you gears as a positive number. The gears are not taken from the register and no items are exachnged, basically a gear dupe. The register is right next to the shop. 

Using version 0.2.2 on server version 1.19.3

SeveredSkullz Thats fine, you have a good vacation and try not to stress about a silly game =D. have a lovly vacation =D. ^v^

Kara - I am currently on vacation with my family and dont have access to my PC for a while. When I return I will be happy to take a look into it. The only thing that comes to mind is if the register is in an unloaded chunk when the sale is made. I dont know how far away you are considering "near" in this case, but if we are talking hundreds of blocks that is likely the cause. Currently I dont have any code to try and load the chunks before a sale is made. Vintage Story has a way to Force-load chunks, but no way to *UN*force-load the chunk. It was a problem I have been looking around for a solution for a while to no avail, and as such I did not want to force-load hundreds of chunks for all the registers and stalls, likely reducing performance on all of your servers.

I have been getting reports from my players that the shops have randomly stopped working. us breaking the shop and them placing a new one needs to fix the issue, although i dont have any crash reports or errors to go off of, just reports from players D=. ill report if i get more into from the. 

It seems the Registers seem to break when not placed near the shalls selling items. 

This make the stalls through errors like they are out of stock or unregistered/not set up correctly

Issue should be fixed now. Added an additional failsafe in order to prevent that from messing up the GUI even if it doesnt get cleared up in the future for whatever reason.

I also fixed the Mod's Game Dependencies, so you shouldnt see that "Failed parsing version string '1.19.0-rc.*'" error anymore on 19.0. Im aware Tyron fixed this bug in 19.1 but oh well :D

WickedSchnitzel / Kara - Will try and take a look at this tonight. Thanks for letting me know. Didnt seem to be an issue in the release candidate version, so Ill look into what changed.

seems to be buggy in 1.19.1. -shop wont get displayed in the drop down menu until you relog. -old shops will display even if the cash registers have been destroyed

Not sure if its a bug or What, but Old "shops" are not being removed from the list. i am also unable to create New shops after pressing save. 

WickedSchnitzel - That was the format for the Release Candidates, which is what the current 2.0 version was built for. You can safely ignore this warning - It wont cause any errors.

[Warning] [vinconomy] Dependency 'game': Failed parsing version string '1.19.0-rc.*' at index 10: Unexpected character '*' in PRE_RELEASE identifier (best guess: 1.19.0-rc)

if you ddi add automatic conversion you could also include an ATM already setup to exchange between those rates as well

Alatyr I do not have any plans on adding support for 2 different types of currency, as it does not make any sense to in my opinion. Take the US Dollar - you have whole and partial dollar amounts. If something cost me $1.50, I do not HAVE to have 1 USD and 2 Quarters. I can have 6 Quarters instead, or 15 Dimes. You can set the price to the equivalent of what it would cost in Rusty Gears, and have a Temporal Gear trade in the ATM.

As an example, say I wanted to have a stack of Turnips at 5 Rusty Gears and 1 Temporal Gear. I could have 1 Temporal Gear = 10 Rusty Gears, and thus would set the price at 15 Rusty Gears. Players then could use either 15 Rusty Gears, or trade their Temporal Gear at the ATM for 10 Rusty Gears, and then buy the item.

I have been toying with the idea of being able to automatically exchange currencies - but I am worried about players potentially trading an item they did not intend due to the automatic nature of things. Will need to come up with a solution to that before I actually implement it.

If you can think of a reason that I absolutely must support 2 different types of currencies, please let me know and I will look into it. As the code is written, it would take a significant amount of work to re-write the entire logic for all the stalls in order to be able to support this - almost a complete rewrite. I am not going to be making that effort unless there is an absolute *need* for it.

Is it possible to add the ability to set a price for 2 items? For example, set the price equal to 1 temporal gear and 1 Rusty, for example.

Nice thank you very much I was just waiting for it :-)

I have uploaded the 0.2.0 Release for 1.19-Pre... Keep in mind this new version is NOT COMPATIBLE with older versions of the mod. The save system was migrated over to a new SQLite database and any attempt to use shops registered under the old system WILL NOT WORK.

Hmm my idea was Like having a Register what Have like a tube. Or something simmilar What could go down into a Storage area, I have trouble to always empty the Register out when my Friend sells his stones. But thank you for hearing me out.

TimSithis Im open to ideas, but thats essentially what the Register already does - How would it be any different from a mechanics perspective? The only difference is you have a model that looks like a safe instead of a cash register. I do have plans for a sort of "treasury" when I finally get to the Cities / Claims aspect of things, but that wouldnt be a part of Vinconomy.

Hmmm do you think you will someday make it possible that Your Currentcy..or Let's say the money you get can be put into something Like a HUGE Safe for keeping and storage?

Honestly a fantastic mod to build a functional/aesthetically-pleasing shop with. I love it!

Screwy -   It is highly unlikely it will be in the next update, as I have one thats been in the works and I have been trying to get finished for a few weeks now. IRL issues keep getting in the way and preventing me to finish the final features (If you're curious, check the Mod Page on discord). As for the food - you are right, it is intentional that the items must match exactly - especially for food. I did not want situations where players might abuse the stalls with only 1 item that was "fresh" and the rest borderline rotting / rotten. The UI is going to show the first item that is not an empty slot for simplicity's sake, and that fact could be abused. Internally, I am doing a simple "Satisfies" check which is entirely built into VS - meaning it's not my code. In order to do what you want I would have to roll my own - which is totally doable, but it might just take some time with everything going on right now. I can certainly add it to the list, and perhaps just put the replacement implementation behind a configuration variable to use exact matching or approxomite. Another solution is I can just average out the decay rate on all the item stacks when you try to add a new stack. I will play around with it and see what feels right.

As for your message about it not showing item info in the customer UI, what exactly do you mean? It should be showing you a passive item slot containing the first non-empty item for that slot. I have not heard of any issue with this from anyone else, and I have not seen it in my own testing. If possible, could you please provide a screenshot of the problem either here or up on discord to demonstrate what you mean?

SeveredSkullz I'd like to thank you so much for this awesome mod! We use it on our upcoming German server and it enables us to manage almost every aspect of our economy.

But one thing is a bit... annoying. I understand that it has to be the exact same item on all 9 slots of a stall. But this makes it almost impossible to get more than one food item in there.
Is there any way this could be fixed in the next update? Maybe my either ignoring the decay rate while checking if it is the same item, or by some tolerance value for this variable.
And there is no item info in the customer UI. Is this intended? Can we have a config bool for that?

WickedSchnitzel - You shouldnt need World Edit simply to remove the shop. If you are in Creative Mode it will bypass the protection and allow you to remove it. That was a request by AngelLord via Discord that I added in 0.1.4. Im also sitting on a change that allows players to use shops within claims so you will no longer have to use /allowuseeveryone that was requested by him as well up on discord. They were using Claims as a sort of "rental" property and didn't want to have to manage adding/removing everyone all the time. Im also in the process of refactoring the code to allow sales to be conducted without having to have all the items in your hand, which is preventing me from pushing said change right now. I hope to have time this weekend to finish up the implementation and get that out to you guys soon.

But yes, the stalls / registers have protections in place in that they do not need to be within claimed land to be protected. As you saw, it wont allow anyone to break the shop unless they are the owner, or an Admin currently in Creative Mode (You HAVE to be in creative mode). If a player has left the server, and you believe they are not coming back, you can also use the "/vicon setowner [player] [x] [y] [z]" command for the stall/register in question to take over ownership of it instead of outright removing it.

paintmoses - Assisted via Discord :)

How to you find the commands for your mod, I am trying to make shops I can use and edit, if thats a possibility?

Thanks in advance.

Wow, that's great. Thank you very much SeveredSkullz!

I'm going to try it :-)

fipil - Just pushed 0.1.4 which adds the features you requested. Still dont have much free time with all the chaos, but its still next on my "todo" list for ATMs.

Thank you SeveredSkullz!
Your solution would be fine. Another approach could be introducing of some admin item so user should hold it to open the admin view. But I understand that this would unpleseantly change the existing workflow to which users are already used to.

I noticed the ATM block in the future plans, so I'm looking forward to it. :-) Hope that the ATM design will look medieval, we build a medieval world so some modern ATM machine with a display would be a little bit problem for us :-D.

I'd be also very nice if your mod could work with our smaller denomination Copper wheels. For example user wants to buy a carrot priced 4 copper gears. Then he'll pay 1 rusty gear and the shop returns him a change: 6 copper gears. 

Fantastic mod! It seems that sometimes though, it will say a player does not have enough of a currency item in hand when in fact they do. The shop is well stocked too, so I cannot see why this would happen. It seems to happen randomly, and relogging does not solve. 

fipil It is not possible to check for an arbitrary key as a Hotkey, unfortunately. While I cannot add any more hotkeys, I can check if the item in your hand is the currency item while you are sneaking to allow you to purchase items from your own stall. I will add this to my "To Do" list along with the ability to remove other players stalls/registers as an admin someone else requested via Discord. Should be able to get to it in the next day or two, provided I get a break from the IRL chaos.

Also, please note that an ATM block explictly designed for currency conversion is on my Future Plans / Roadmap in the mod description. Eventually, you won't need a dedicated shop to do this. I just need to get the free time back to be able to implement it. 🙃

Hi SeveredSkullz

I love your mod. I see only one big problem: As an owner of the shop, I cannot USE the shop. You can ask why want I use my own shop? The reasons are the following:

• I want simply test my shop, if it works and is configured properly.
• We have two kind of money on our server, the vanilla rusty gears and the copper gears, provided by our mod, which we use as change: 1 rusty gear = 10 copper gears. I created an admin shop, where player can change 1 rusty gear by 10 copper gears and also to change 10 copper gears to 1 rusty gear. Problem is that I cannot USE the shop. I'm an admin but also a player which want to use the shop as an ordinary player.

So please, would it be possible to change behaviour so the shop configuration will open only by using some hotkey together with a mouse click and if player does not use the hotkey, the shop will act as a shop for him?

Thank you very much.

Fipil

JunidO - I'm not sure what you mean by that. If you are referring to the number of slots that is used to sell the items to other players, then no I do not have any plans on increasing that amount. I feel that 36 slots for stock is way more than enough. The whole design philosophy is for you to have a large shop if you want to sell large quantities of items. If you need more inventory slots for a given item, you can always use more than one Stall Slot. There is nothing preventing you from selling 9 stacks of Turnips in each of the 4 Stall Slots.

If that is not what you mean, I would need a bit more clarification.

A great mod, I've been waiting for it for a long time. I'm excited to see what else comes next.
Could you integrate extra storage space for things you want to buy through your shop or expand the storage space of the shop register?
Hope you understand what I mean, unfortunately I can't speak English and have to use a translator.

Hey WickedSchnitzel Dealing with some maddness IRL so havent gotten a chance to work on it since the last release.

Clothing Stand is still WIP as of right now. It works, but I dont have a crafting recipe for it yet since I'm fighting with some positioning - though I might just give up on being a perfectionist and take a "Close Enough" approach. Without going though and doing a whole slew of custom models for each clothing piece, I dont think they will ever line up correctly / not overlap.

As for the Chiseled objects, I absolutely plan on getting that working. You can still sell them, but they wont be displayed correctly currently. The only workaround right now is to open up the UI, which should render the item's icon so you can atleast get a glimpse at what it is. I am also toying with an idea of having some sort of "Multiblock" display for those creations that take up more than 1 block (like a 3x3x3 creation).

The thing is that people would like to sell chiseled objects as well, also clothing etc. Will support for these objects be added in the future? If you have problems with implementing it, maybe take a look at CAN Market's source, as it works there?
mods.vintagestory.at/canmarket

Wow! What a brilliant mod! Looks like the shopping mod I was dreamed of :-). I'm going to try it! Thanks. Keep up the perfect work.

Thanks for working with Ket! We've reinstalled the new v1.1 and things seem to be working fine now. I appreciate the explanation. Keep at it and happy modding!

Thats why I said "Redownload" - While I was working with Ketamine/Horizons on Discord, I was had mistakenly changed 1.1's Zip and hadn't made a new version (Was still trying to figure out the site). At the time I think there was only like 8 people had downloaded it, so I didnt think anything of it. I assume you were one of those 8 people.

If you redownload and reinstall v1.1 and its *still* erroring out, please let me know - and preferably send me your save so I can take a look.

It happened with 0.1.1, which is the latest version SeveredSkullz

WickedSchnitzel Not sure if you are up to date or not on the mod, but this issue was already addressed below from help with Horizons. Redownload v0.1.1 and the issue should be fixed.

Run ok for a while, then crashed the whole server with

[Server Error] Exception thrown during handling event OnSaveGameLoaded: System.NullReferenceException: Object reference not set to an instance of an object.
at Viconomy.Registry.ShopRegistry.GetCount()
at Viconomy.ViconomyModSystem.OnSaveGameLoading()
at Vintagestory.Server.ServerEventManager.TriggerSaveGameLoaded() in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Server\ServerEventManager.cs:line 474

Horizons I spoke with Ketastrophe via discord and he sent me the world files from your server. I have narrowed down the root cause being an edge case where the game saved when you had no Registers placed. My clean-up code kicked in to remove the listing for that register, and ultimately the serialization of an empty Dictionary caused the value to be saved as "null" for your Player UUID. When the game then went to load your Registers, it got null instead of the Dictionary to loop through. Problem fixed - And fortunately, I can say that Fantasy Creatures (or any mod) had nothing to do with this issue.

@SeveredSkullz AHH ok alright! then i said nothing :D 

Horizons Unfortunately I am still unable to replicate the issue you are facing. I created a new world, Set up 3 different Registers, with 4 Stalls each. I then saved the game, quit to the main menu, installed Fantasy Creatures, and reloaded the game.

Thank you for your time testing for our bug!

Because you were wondering, the method used to determine Vinconomy is the issue was removing half the mods, seeing which half still had the error, and then repeating. We narrowed it down to seeing the error with only Vinconomy installed. With all other mods except Vinconomy installed, the error did not appear.

This morning we did more testing, including in singleplayer, a copy of the server, and the original server. We found that the issue seems to be linked to the save file itself. A new save does not have any issues with Vinconomy or Vinconomy with our other mods.

After further testing with a new save file, we managed to replicate the error by first installing Vinconomy, testing it in game, and then Fantasy Creatures (which was previously removed from our server), which triggered the set of errors right away. It seems that despite removing Fantasy Creatures, something about how it alters the save file does not play well with Vinconomy.

We did find an additional error in the log:

29.9.2023 08:41:11 [Server Error] Exception thrown during handling event OnSaveGameLoaded: System.NullReferenceException: Obje ct reference not set to an instance of an object. at Viconomy.Registry.ShopRegistry.GetCount() at Viconomy.ViconomyModSystem.OnSaveGameLoading() at Vintagestory.Server.ServerEventManager.TriggerSaveGameLoaded() in C:\Users\Tyron\Documents\vintagestory\game\Vintagestor yLib\Server\ServerEventManager.cs:line 474

Once again, thanks for your time. We fell in love with the mod right away and can't wait to play with it on a new save!

😁 cool so far , i found some simple issues i guess, the list from the shop does not update by itself by removing a "Shop register" and for adminshops i think would be better that the currency would deleted

I was fairly confident upon seeing the stacktrace that my mod had nothing to do with that error. To be sure though, I went and made a new world, set up a few simple shops, and started a temporal storm with "/nexttempstorm now" and did not crash. Retried on 2 additional worlds for a total of 3. Could not replicate the issue.

Im not sure what is giving you the impression that Vinconmy is at fault here, but looking at the source of RiftWeather.cs up on Github the root cause is trying to getting the next drifter to spawn. I assume you have a mod that modifies drifter spawns. This is obviously not modified by my mod - everything here is custom.

Getting fatal errors when there's a temporal storm. To our surprise, we narrowed it down to Vinconomy. Can you take a look, please?

The error:

28.9.2023 17:55:00 [Fatal] System.NullReferenceException: Object reference not set to an instance of an object.
at Vintagestory.GameContent.ModSystemRiftWeather.onServerTick(Single dt) in C:\Users\Tyron\Documents\vintagestory\game\VSSurvivalMod\Systems\Rifts\RiftWeather.cs:line 211
at Vintagestory.Common.EventManager.TriggerGameTick(Int64 ellapsedMilliseconds, IWorldAccessor world) in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Common\EventManager.cs:line 59
at Vintagestory.Server.CoreServerEventManager.TriggerGameTick(Int64 ellapsedMilliseconds, IWorldAccessor world) in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Server\ServerEventManager.cs:line 124
at Vintagestory.Server.ServerMain.Process() in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Server\ServerMain.cs:line 881

PatrickStar10 - It is for both, meaning in order for it to function at all it needs to be on both the Client and Server. It will work fine in Singleplayer, but I dont know what use it will be for you unless you enjoy buying and selling goods to yourself (Which you cannot do anyway - Stall owners will only get the Owner UI and Interactions).

Does this work in singleplayer or is it a client mod only right now?

The future plan for NPCs being able to buy sounds really nice 

pls add donation link :D this is the mod i already waited for 

This would pair well with Xel's Coinage or Zolgrim's Coinz.