Commands

Is there an update for 1.19.4?

Receiving this error whenever someone tries ".ws sync" on our server:


27.10.2023 09:37:40 [Error] System.NullReferenceException: Object reference not set to an instance of an object.
at VsWaypointSharing.VsWaypointSharing.OnShareRequested(IServerPlayer fromPlayer, WaypointShareMessage wsm) in I:\Documents\Git\VsWaypointSharing\src\VsWaypointSharing.cs:line 284
at Vintagestory.Server.NetworkAPI.HandleCustomPacket(Packet_Client packet, ConnectedClient client) in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Server\API\NetworkAPI.cs:line 40
at Vintagestory.Server.ServerMain.ProcessNetMessage(NetIncomingMessage msg, NetServer mainSocket) in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Server\ServerMainNetworking.cs:line 138

We recently moved our save file to this server from a different machine. I'm wondering if that has something to do with it?

EDIT:
It works when I reload the world on the old server. 
If I generate a new world on the current server, I can sync without issue. So I think it must have something to do with the fact that the world was generated on a different server? I have no idea how to fix this though.

EDIT 2: 
I had my friend who was missing rejoin the server and try it, then it worked. What I mean is: he hadn't actually connected to the new server IP until now, and I think that's what the problem was. When someone went to sync, and the code got to the point where it calls the GetPlayerDataByUid method to get the name of the person with his ID, it returned null because that player didn't exist in the server's playerdata.json yet. I tried adding him manually but it kept reverting it whenever we'd reload the server. Anyways it's fixed now, but adding a null check for this might be a good idea still.

@Inakibari Are you using the right version of the mod with the appropriate version of the game? Also, as far as I know, you can't load two versions of the same mod at the same time, so that might be the error you're seeing. If you post the specific error from your logs, I might be able to tell you more but I can't do much with just the info from that screenshot.

https://i.imgur.com/9gQx2g1.png

Well. 1.0.5 works now, but the new 1.0.6 has the same issue as last time. What's going on here?

@HostilHobbit good idea I used both mods myself. @Astarael I know these mods were compatible but the new updates have probably messed something up, I think Auto Map Markers needs updating 

Not sure what's going on here, but the newest version straight up doesn't work. Seems to have a dependency?

@Astarael Thanks for the response, i understand if its not something possible heres a link to the mod https://mods.vintagestory.at/automapmarkers#showchangelog .

@HostilHobbit I'll try to take a look when I have some time, but it's possible the two are incompatible.

This seems to break the auto map marker mod that makes markers on certain item pickups

@teslov thanks, I'll try to take a look next week. The logging fix was for the chat window, not for the logging API that (apparently) goes to file. I'll see if I can address both of the ones you mentioned.

Hey, the log spam wasn't really fixed and my logs bloated to 23,7Gib after two players enabled autosync :D
"Auto-syncing client [ID]"
And then fatal error about An item with the same key being already added. It appeared multiple times a second.

Sorry for not providing actual log, I shift-deleted it as my poor storage was completely full.

@Astarael I haven't noticed any errors when I do I'll let you know :D Thanks for the update ;)

@Tizuby this is fixed now

@Frovix I uploaded an updated version which I tested on the latest client. Please let me know if you're still having issues.

could you update to the current version?

1.18 update?

Can you disable the log spam please? Every exact minute it logs "auto-sync thread running".