fipil

Is there a version in the works to fix the double movement effect that weapons do when clicking 1?

I added the version 1.5.2. The version works with VS v1.19.0 and above.

The version fixes the double animation issue and does not crash with VS v1.19.4-rc.1.

Important notes:

Unfortunatelly, according to answer from Tyron, the old in-code animation system has been removed in the 1.19. This mod has been based on this system. This change caused the double animation issues. I made some raw fix, so the weapons animates just once. It's finetuned for the v1.19.4-rc.1 and above. So:

• If running with VS 1.19.3 and earlier, it'll work, but sound is not synced with animation if you hold the mouse to repeat attack.
• If running with VS 1.19.4 and later, the sound will be synced quite well.

Another problem caused by the system removal is the following: the speed of weapon attack animation is the same for a similar weapons. The animation speed cannot be controlled in code anymore. So please count with that, maybe some weapons are now quite OP.

There is a way how to fix it: I have to create an extra animation for each weapon. Yes, it'll be nicer, but it's a lot of work, the whole mod should be rewritten. I'll study how to do that and I'll probably do it, but it will take some time. So you have to settle for the mentioned fixes for now. I hope that the mod is usable anyway. Enjoy :-)

Please test and let me know if there are any other issues.

I added a new update v1.5.1 of the mod for the VS v1.19.4-rc.1 - it shoud work with the version.
Also fixed the double animation issue.

Please test and let me know if there are any other issues.

FYI: _Crowley_, Pumasoko, Bramimond

Heya! Looks like update v1.19.4-rc.1 kinda killed the mod, I'm not sure if it's just me, or some mod clashes, but the moment I load up the mod, my worlds won't load. Do you think it's possibly related to the Animation loop fix? The mod is a cornerstone of our server! Would love to be able to keep it. 

_Crowley_ There are some fixes in the yesterday's VS update v1.19.4-rc.1, related to the animation: "Fixes to some animations endlessly repeating after an action".
Maybe it helps? I didn't try it yet.

I was investigating and it's probably somewhere in the VS code, related to the new first person mode changes in the 1.19. I'll continue investigation, if the update didn't help.

Any update in regards to the double animation issue? :) I love the mod but im having a hard time using it in combat with this current issue

Pumasoko thanks for letting me know, I'll investigate it. 

Hi I don´t know why but in First person mode on 1.19 the weapon attack animation always plays twice. This makes combat kind of jenky

testing now let you know 

Hi!
I just upgraded the mod for .NET7 + repacked to VS1.19. 
Please test and give me a feedback in case of some problems. Thanks!

Fipil

ya it works great 

does this work on latest stable patch 18.15? thx

Works like a charm. Thank you very much <3

@DragonRelic

Yes. I'll update this mod as long as the original mod will remain untouched by Mr1k3.

@BlueFuryDragon, looking at your crash log, I can see that you're using the original version of the weapon pack alpha. See the fifth line of your crash log:
8/16/2023 7:59:58 PM: Critical error occurred in the following mod: weaponpacka@1.3.1

The original version is not updated to the VS 1.18.* versions.
That's the reason why I made this unofficial update.
Try to use this update, instead of the original version 1.3.1. 

1.18.8 net7

Game crash as soon as I tryed to use the Malachite weapon basalt version.

Running on 64 bit Windows with 32670 MB RAM
Game Version: v1.18.8 (Stable)
8/16/2023 7:59:58 PM: Critical error occurred in the following mod: weaponpacka@1.3.1
Loaded Mods: weaponpacka@1.3.1, ancienttools@1.5.8, metalrecoverydon@1.0.1, backpackpackplus@1.0.3, betterarchery@3.0.0, betterclay@1.0.1, bettercrates@1.6.0, betterpoultice@1.0.0, betterruins@0.2.1, composter@1.0.5, cralutweaks@1.0.2, extrainfo@1.5.0, quickerbarrel@1.1.1, juicyores@1.0.0, justmoreruins@0.9.2, moredrifterloot@1.5.4, moremolds@1.4.2, OresAPlenty@3.1.0, primitivesurvival@3.2.7, sortablestorage@1.9.0, temporal_gears_stack@1.0.0, game@1.18.8, abcsreborn@0.1.2, alloycalculator@1.0.0, animalcages@2.1.5, autoloot@1.0.1, betterfirepit@1.1.1, carryon@1.3.0, commonlib@2.2.0, farmlanddropssoil@1.4.0, hudclock@3.3.0, medievalexpansion@3.10.0, moreicons@1.0.4, morepiles@1.4.3, petai@1.7.10, primitivetools@1.4.1, scythemold@1.0.0, statushud@1.4.3, stepup@1.2.0, stillnecessaries@1.0.0, stonebakeoven@1.0.5, th3dungeon@0.1.3, creative@1.18.8, vsquest@0.4.1, survival@1.18.8, vsvillage@0.7.3, waypointcolours@1.1.1, workbenchexpansion@1.7.0, cats@1.7.0, playercorpse@1.8.0, vanity@1.0.0, wolftaming@1.7.3
System.MissingFieldException: Field not found: 'Vintagestory.API.Common.ModelTransform.Translation'.
at CustomWeaponSpeed.NormalSwordChargeNone.OnHeldAttackStep(Single secondsPassed, ItemSlot slot, EntityAgent byEntity, BlockSelection blockSelection, EntitySelection entitySel)
at Vintagestory.API.Common.CollectibleObject.OnHeldUseStep(Single secondsPassed, ItemSlot slot, EntityAgent byEntity, BlockSelection blockSel, EntitySelection entitySel) in VintagestoryApi\Common\Collectible\Collectible.cs:line 1044
at Vintagestory.Client.NoObf.SystemMouseInWorldInteractions.HandleHandInteraction(Single dt) in VintagestoryLib\Client\Systems\Player\MouseInWorldInteractions.cs:line 310
at Vintagestory.Client.NoObf.SystemMouseInWorldInteractions.OnGameTick(Single dt) in VintagestoryLib\Client\Systems\Player\MouseInWorldInteractions.cs:line 165
at Vintagestory.Common.EventManager.TriggerGameTick(Int64 ellapsedMilliseconds, IWorldAccessor world) in VintagestoryLib\Common\EventManager.cs:line 59
at Vintagestory.Client.NoObf.ClientMain.MainRenderLoop(Single dt) in VintagestoryLib\Client\ClientMain.cs:line 796
at Vintagestory.Client.NoObf.ClientMain.MainGameLoop(Single deltaTime) in VintagestoryLib\Client\ClientMain.cs:line 712
at Vintagestory.Client.GuiScreenRunningGame.RenderToPrimary(Single dt) in VintagestoryLib\Client\MainMenu\Screens\GuiScreenRunningGame.cs:line 200
at Vintagestory.Client.ScreenManager.Render(Single dt) in VintagestoryLib\Client\ScreenManager.cs:line 668
at Vintagestory.Client.ScreenManager.OnNewFrame(Single dt) in VintagestoryLib\Client\ScreenManager.cs:line 643
at Vintagestory.Client.NoObf.ClientPlatformWindows.window_RenderFrame(FrameEventArgs e) in VintagestoryLib\Client\ClientPlatform\GameWindow.cs:line 75
at OpenTK.Windowing.Desktop.GameWindow.DispatchRenderFrame()
at OpenTK.Windowing.Desktop.GameWindow.Run()
at Vintagestory.Client.ClientProgram.Start(ClientProgramArgs args, String[] rawArgs) in VintagestoryLib\Client\ClientProgram.cs:line 312
at Vintagestory.Client.ClientProgram.<>c__DisplayClass9_0.<.ctor>b__1() in VintagestoryLib\Client\ClientProgram.cs:line 129
at Vintagestory.ClientNative.CrashReporter.Start(ThreadStart start) in VintagestoryLib\Client\ClientPlatform\ClientNative\CrashReporter.cs:line 93

Event Log entries containing Vintagestory.exe, the latest 3
==================================
{ TimeGenerated = 8/16/2023 7:55:49 PM, Site = , Source = Windows Error Reporting, Message = Fault bucket 1273209627708249444, type 4
Event Name: APPCRASH
Response: Not available
Cab Id: 0

Problem signature:
P1: Vintagestory.exe
P2: 1.18.8.0
P3: 6492041a
P4: openal32.dll
P5: 1.23.0.0
P6: 63dd31ad
P7: 40000015
P8: 00000000000df046
P9:
P10:

Attached files:
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER7BA2.tmp.mdmp
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER824A.tmp.WERInternalMetadata.xml
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER826A.tmp.xml
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER8268.tmp.csv
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER8289.tmp.txt

These files may be available here:
\\?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_Vintagestory.exe_8de098f737c744fcb2cfb2449b6f09668c35b_9d23d9f5_f52b9105-2a39-4876-9d0d-935d55b39932

Analysis symbol:
Rechecking for solution: 0
Report Id: 1da38042-fb90-4f39-93c2-e770b0261789
Report Status: 268566528
Hashed bucket: 42c222969642167ad1ab596920285564
Cab Guid: 0 }
--------------
{ TimeGenerated = 8/16/2023 7:55:46 PM, Site = , Source = Application Error, Message = Faulting application name: Vintagestory.exe, version: 1.18.8.0, time stamp: 0x6492041a
Faulting module name: openal32.dll, version: 1.23.0.0, time stamp: 0x63dd31ad
Exception code: 0x40000015
Fault offset: 0x00000000000df046
Faulting process id: 0x629c
Faulting application start time: 0x01d9d090ce8ef5ab
Faulting application path: C:\Users\ylfgr\AppData\Roaming\Vintagestory\Vintagestory.exe
Faulting module path: C:\Users\ylfgr\AppData\Roaming\Vintagestory\Lib\openal32.dll
Report Id: 1da38042-fb90-4f39-93c2-e770b0261789
Faulting package full name:
Faulting package-relative application ID: }
--------------
{ TimeGenerated = 8/16/2023 4:43:17 PM, Site = , Source = Windows Error Reporting, Message = Fault bucket 1595974493794080458, type 5
Event Name: RADAR_PRE_LEAK_64
Response: Not available
Cab Id: 0

Problem signature:
P1: Vintagestory.exe
P2: 1.18.8.0
P3: 10.0.19045.2.0.0
P4:
P5:
P6:
P7:
P8:
P9:
P10:

Attached files:
\\?\C:\Users\ylfgr\AppData\Local\Temp\RDR3FFF.tmp\empty.txt
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER4000.tmp.WERInternalMetadata.xml
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER4010.tmp.xml
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER4018.tmp.csv
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER4048.tmp.txt

These files may be available here:

Analysis symbol:
Rechecking for solution: 0
Report Id: 8c4b094d-59ce-44b5-97ee-d7625c063e79
Report Status: 268435456
Hashed bucket: 8ab961cec6a2b8d566260a58a52e16ca
Cab Guid: 0 }

Will this be updated again?

Did Mr1k3 ever say whether or not they were going to continue updating their weapon mods?

Great mod! I love it!

Ajnador I don't know, try to search in description + comments on the original mod page, maybe there is any note about XSkills.

RachelTGG No, I don't plan to update any other mod of the Mr1k3. I would do that only if Mr1k3 would invite me to help him as a contributor.

Woudl this be compatible with XSkills? specifically the Combat skill where swords do extra damage

Do you plan on updating the Gamma pack too?