Rythillian

attributes wtih saved names will remain on items but won't be displayed on hover, otherwise nothing

What happens to the items if this is removed from the server?

Working in 1.20.1

Pasting here in case it means something to you! Thanks!

client-main.txt

10.12.2024 23:41:32 [Error] [blacksmithname] An exception was thrown when trying to start the mod:
10.12.2024 23:41:32 [Error] [blacksmithname] Exception: Could not load file or assembly 'toolworks, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'. The system cannot find the file specified.
at blacksmithname.src.Compat.BlacksmithNameToolworkCompat.StartClientSide(ICoreClientAPI api)
at Vintagestory.Common.ModLoader.TryRunModPhase(Mod mod, ModSystem system, ICoreAPI api, ModRunPhase phase) in VintagestoryLib\Common\API\ModLoader.cs:line 664
10.12.2024 23:41:32 [Error] Failed to start system blacksmithname.src.Compat.BlacksmithNameToolworkCompat

Do you intend to add compatibility with the Toolworks mod? KenigVovan

This mod creates the error in my client-main log:
[Error] Found closing tag <strong> at position x but <font> should be closed first. See debug log for full text.

The debug log shows this:
Forged by: <font color="#ffffff">Entity</strong>

The log will quickly fill up with these errors if I scroll past or interact with items that have the forged by descriptor.

Ryuu

just to add name to a pot/bowl is easy but it would disappear when they are placed as block/blockEnity in a world. To solve it mod would need to replace vanila blockEnity to be able to save inside it  player's name. I did it this way for lantern back then, but dropped it. (Maybe there is a better solution for that, which I'm not aware about ofc)

Since we have this for blacksmithing, what about one for who cooked what meal or who put food in a crock? Have you thought about those too? :D 

Yes, sounds simple.

that sounds like a good solution for the helve hammer
names on other things would be neat for sure

Alatyr

you mean when helve hammer finished a tool itself? and just place name of the player who placed ingot on an anvil?

I would also like to see the name of the blacksmith appear when crafting a tool on a helve hammer.

Alatyr

It is possible, it would just add name at the moment when armor/shield is crafted through the crafting grid

Is it possible to add a blacksmith name for armor and shields?

Barhandar

name attribute should be in GlobalConstants.IgnoredStackAttributes now, which fixes the problem with trader but probably will let you stack tool heads without smith name with other which has one and copy attribute

To add to the "doesn't work with xskills duplicator": picks with the smith's name also don't work for getting the map to Resonance Archives, and stackable named items (e.g. arrows) don't stack with non-named ones. The name metadata should be ignored for both, the same way toolmode metadata is, and erased in the second case because having unnamed stackables is preferable to being able to change the smith name.

KenigVovan  Game Version: v1.18.13 (Stable)
9/29/2023 7:08:16 PM: Critical error occurred
Loaded Mods:
System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'The ThreadLocal object has been disposed.'.
at System.Threading.ThreadLocal`1.GetValueSlow()
at Vintagestory.API.Common.CollectibleObject.UpdateAndGetTransitionStatesNative_Patch0(CollectibleObject this, IWorldAccessor world, ItemSlot inslot)
at Vintagestory.API.Common.CollectibleObject.AppendPerishableInfoText(ItemSlot inSlot, StringBuilder dsc, IWorldAccessor world) in VintagestoryApi\Common\Collectible\Collectible.cs:line 1672
at Vintagestory.API.Common.CollectibleObject.GetHeldItemInfo_Patch0(CollectibleObject this, ItemSlot inSlot, StringBuilder dsc, IWorldAccessor world, Boolean withDebugInfo)
at Vintagestory.GameContent.GuiHandbookItemStackPage..ctor(ICoreClientAPI capi, ItemStack stack) in VSSurvivalMod\Systems\Handbook\Gui\GuiHandbookItemStackPage.cs:line 35
at Vintagestory.GameContent.ModSystemHandbook.onCreatePagesAsync() in VSSurvivalMod\Systems\Handbook\Handbook.cs:line 75
at Vintagestory.GameContent.GuiDialogHandbook.LoadPages_Async() in VSSurvivalMod\Systems\Handbook\Gui\GuiDialogHandbook.cs:line 489
at Vintagestory.GameContent.GuiDialogHandbook.<loadEntries>b__20_0() in VSSurvivalMod\Systems\Handbook\Gui\GuiDialogHandbook.cs:line 117
at System.Threading.QueueUserWorkItemCallback.Execute()
at System.Threading.ThreadPoolWorkQueue.Dispatch()
at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()

sorry about that =P

Kara

A crash log could be usefull

Once this mod is added into a server/world, it can not be removed from that server/world or it will result in clients crashing due to having an invalid item in inventory. tried pulling it from my server, to make the shops be able to reconize all items (dosnt play 100% nice with xskills duplicator perk) when you duplicate a item, the dupped item dosnt have the "forged by:" tag on it. as stated by Alatyr before. so kind of oof, that it cant be pulled out at this time.

Sometimes the smith's name does not appear on the item. I'm playing with XSkills, maybe dealing with the duplicator perk or something else.

Ryuu

should work

How does this fair with the mod "RPG Item Rarity"? Does there need a compatibility created or will it work fine right out of the box and is friendly with it?

Alatyr

just built with net7, but seems to work correctly with xskill

Alatyr

Last time I was checking why it didn't work with XSkill it has its own wrapper for smithing and vanila code wasn't called or was changed (I don't remember clearly)
and transplier just was ignored. 
I'll take a look how it is now and if I can somehow workaround or just create sub mod which will depend on XSkill

KenigVovan It's not working with XSkills on server

Ziru

yes

is this working in 1.17.9?

StewBag, 1.0.2 version? Any other mods installed?

Causes client crash when placing heated ingot on anvil.

The name of the person who made the tool's head will remain after putting tool's head on stick.

Thank you for suggestion, i'll change lang file.

Does this factor in the person who made the tool's head or will I become a master smith by putting tool heads on sticks? 😄

As an additional suggestion, I believe it would make more sense for it to say "Forged by..." instead of "Smithed"