Goodnight, sweet prince. Your service will be remembered!

Added to vanilla now. o7

Your mod was so awesome, they added the idea to the base game.  I just want you to know that I have appreciated this mod for YEARS.  You rock!

Congrats on having your idea of hanging oil lamp implemented officially within vanilla game in 1.22  - gj! 😎

Would it be possible to add compatiability with the additional ceramic types from the Bricklayers mod? 

Lodey seems to be server related. After a restart of the VS Server the textures got loaded and everything looks nice again :)

Thanks for your amazing work

voxelsword Unfortunately some concessions had to be made in order to get the lamps to hang from the bottom of blocks. The reality is that the oil lamp block is perhaps the only light block that doesn't have its own class in the code: it uses the torch class. In order to attach the oil lamp to ceilings I had to remove the BlockTorch class from the oil lamp code. Some functionality is lost as a result, such as being able to use the lamp to light torches and altering the conditions for how the player holds the lamp in some cases. Someone with more modding experience than me could probably produce a BlockLamp class that would resolve the issues, but it's out of my wheelhouse.

with this mod installed, oil lamps when put into the off-hand slot aren't held out infront of your character and instead held down at your side as if you aren't holding anything. they still work and emit light but it's a bit odd looking lul

Skaface443 I can't reproduce this issue. Make sure you're on the latest version and have removed the old one from your mods folder. Make a creative test world with only the Hanging Oil Lamps mod enabled to see if another mod is interfering.

Textures for the lamps not loading in 1.21.0, just questionmark blocks where my hanging oil lamps used to be

Honored to be the 100,000th download :)

Now I know why I couldn't find their recipe :D

OMG YES! I've been waiting for an update thank you so much I love this mod. I haven't tested it yet but I will update for any issues I might experience

1.21 😍 this mod is such a little thing and yet I have missed it so much these last few weeks.

Also the lamp not working as a fire starter seems to be a vanilla change, as it hasn't been working for me and as I've been playing 1.21, this mod hasn't been a thing for me for a few weeks.

Sadly this doesn't work in 1.21-0rc2 thanks to the new colors (and probably string changes) for oil lamps.

Hello. There as in issue with this mod where you can no longer light the torch from the oil lamp. Would love to use but relighting torches from these is super useful.

Damn.. not compatible with clayworks..

Great work on the mod. The only issue I am having is that the oil lamps no longer light torches. Is this intended?

Hey Lodey, youre a ten out of ten in my book for this mod. Thank you boss

@Lodey Thank you for getting back tro me! I will try what @radfast has said and see if it works. radfast is right though, I did have an oil lamp in my off hand at the time of the crash. It didn't occur to me that it could have been causing the issue.

Thank you again to both of you!

@Lodey the issue is this:

    {
        "op": "remove",
        "path": "/attributes",
        "file": "blocktypes/clay/oillamp.json"
    },

This causes the crash indirectly, because the game engine has a line of code for the item in the left-hand slot (the off-hand) which reads Block/Item.Attributes.blahblah without a null check on the Attributes.  All vanilla blocks and items, which can be held in the left-hand slot - including vanilla oil lamps - have Attributes and so there is no crash there in vanilla.  Because Hanging Oil Lamps removes all the Attributes, there can be this crash.   (Related Github issue: https://github.com/anegostudios/VintageStory-Issues/issues/4735)

We are fixing vanilla code from 1.20.0-rc.6 but for now, players affected by this cannot join their games or servers, they insta-crash on joining, in the first frame rendered.

Up to you but if you wanted to, you could change the mod to remove only /attributes/attachmentAreas, therefore leaving in the reinforceable: true attribute  (which is probably wanted anyhow, your mod also removes reinforcement from the oil llamps).  Like this:

    {
        "op": "remove",
        "path": "/attributes/attachmentAreas",
        "file": "blocktypes/clay/oillamp.json"
    },

DaftCanuck you could also go into the mod's ZIP folder and edit the file assets/game/patches/survival-blocktypes-clay-oillamp.json yourself if you wish...

DaftCanuck The mod runs fine for me in RC5 so I can only imagine that it's a mod conflict, although that seems unlikely. Make a backup of your world and try loading it with only the Hanging Oil Lamps mod. If it starts up fine then there's probably a conflict. If all else fails you can find me via the official Vintage Story Discord server (Lodeclaw) and I'm happy to help you troubleshoot.

Just had my game randomly crash on me and then it would not let me back in to my save file. I went through one mod at a time and after disabling this mod it finally started working again.

Here is the crash log:

Running on 64 bit Windows 10.0.22631.0 with 32693 MB RAM
Game Version: v1.20.0-rc.5 (Unstable)
2024-12-19 3:15:14 PM: Critical error occurred
Loaded Mods: betterloot@1.0.5, bettertraders@0.0.7, buzzwords@1.7.0, landformoverhaul@0.0.3, cutthefat@1.0.1, hangingoillamps@1.0.2, jacksarmortweak@1.0.0, JacksFirewood@1.1.0, juicyores@1.0.0, millwright@1.1.8, MoreTorchHolders@1.0.0, primitivesurvival@3.7.1, ripened_wild_crops@1.0.0, game@1.20.0-rc.5, vsimgui@1.1.7, betterentityinteraction@1.0.3, BetterProspecting@1.3.0, betterruins@0.4.0, butchering@1.7.2, chickenfeed@1.1.4, composter@1.1.1, configlib@1.3.17, danacancook@0.2.4, fieldsofsalt@1.2.2, firewoodtosticks@1.0.0, foodshelves@1.4.3, improvedhandbookrecipes@1.0.5, mobsradar@2.1.2, monstersonlyunderground@1.0.2, pigfeed@1.0.5, claywheel@1.1.2, prospecttogether@1.4.0, quadfirewood@1.0.0, scarecrow@1.6.1, stonebakeoven@1.1.4, vanvar@6.0.7, creative@1.20.0-rc.5, survival@1.20.0-rc.5
System.NullReferenceException: Object reference not set to an instance of an object.
at Vintagestory.GameContent.EntityPlayerShapeRenderer.RenderHeldItem(Single dt, Boolean isShadowPass, Boolean right) in VSEssentials\EntityRenderer\EntityPlayerShapeRenderer.cs:line 261
at Vintagestory.GameContent.EntityPlayerShapeRenderer.DoRender3DOpaque(Single dt, Boolean isShadowPass) in VSEssentials\EntityRenderer\EntityPlayerShapeRenderer.cs:line 167
at Vintagestory.Client.NoObf.SystemRenderEntities.OnRenderOpaque3D(Single deltaTime) in VintagestoryLib\Client\Systems\Render\RenderEntities.cs:line 81
at Vintagestory.Client.NoObf.ClientEventManager.TriggerRenderStage(EnumRenderStage stage, Single dt) in VintagestoryLib\Client\Util\ClientEventManager.cs:line 188
at Vintagestory.Client.NoObf.ClientMain.MainRenderLoop(Single dt) in VintagestoryLib\Client\ClientMain.cs:line 824
at Vintagestory.Client.GuiScreenRunningGame.RenderToPrimary(Single dt) in VintagestoryLib\Client\MainMenu\Screens\GuiScreenRunningGame.cs:line 161
at Vintagestory.Client.ScreenManager.Render(Single dt) in VintagestoryLib\Client\ScreenManager.cs:line 695
at Vintagestory.Client.ScreenManager.OnNewFrame(Single dt) in VintagestoryLib\Client\ScreenManager.cs:line 670
at Vintagestory.Client.NoObf.ClientPlatformWindows.window_RenderFrame(FrameEventArgs e) in VintagestoryLib\Client\ClientPlatform\GameWindow.cs:line 127
at OpenTK.Windowing.Desktop.GameWindow.Run()
at Vintagestory.Client.ClientProgram.Start(ClientProgramArgs args, String[] rawArgs) in VintagestoryLib\Client\ClientProgram.cs:line 334
at Vintagestory.Client.ClientProgram.<>c__DisplayClass10_0.<.ctor>b__1() in VintagestoryLib\Client\ClientProgram.cs:line 130
at Vintagestory.ClientNative.CrashReporter.Start(ThreadStart start) in VintagestoryLib\Client\ClientPlatform\ClientNative\CrashReporter.cs:line 93

1.20PR9 I am seeing a lot of these in the log for the various orientations: [Error] Missing mapping for texture code #-1 during shape tesselation of block game:oillamp-down using shape game:block/clay/bowl-ceiling_hang, or one of its alternates

The mod seems to work though.

Still works in 1.19.0-pre8. It's very unlikely this mod will ever need updating and should work in perpetuity. The only conflict could possibly be with other mods that significantly change oil lamps.

Can anyone confirm if this works using v.1.19pre?

Ponchoandlefty Yes, works on more recently release.

Does this mod still work in version 1.18.15?

Im trying to install this on my server using /moddb install hangingoillamps (enter) what am i doing wrong Im new to admin

bringitonwimps

the mod is working correctly in 1.18.5

anyone try this in 1.18?

Lodey

Hello, first of all congratulations on the mod. I would like to know if it is possible to update the mod for compatibility with Bricklayers oil lamps. Thank you

I'm not fan of oil lamps hanging off the wall...
But the ceiling options is just soo good
How to disalbe the wall part of this mod? 

This should just be vanilla at this point :/

Can confirm this still works on v1.17.9 (Stable).

Why? It still works.

Anyone willing and able to make a fork of this?

I absolutely love this mod. I am just wondering if you're aware that your mod doesn't work when using the World of Darkness mod. it just reverts the oil lamp back to vanilla usage.

Amigurumi No, sorry.

This is great. Will you be adding Bricklayer's compatibility down the road to add the different colors from that?

Should be working now. Sorry for the inconvenience.

Can verify the question mark cube. 1.16.4. Turned off all mods except this one, created a new creative world, and I get a question mark. Is it possible that it's trying to pull some data that's local, which is why we can't see it, but apparently you are able to? Only thing I can currently think of.

@rboys2 Do you have any other mods that alter lamps or lanterns? Are you running at least version 1.16.4? Try turning off all other mods except for this one and see if it's still broken.

Love this mod idea, but doesnt work for me. Just gives me a cube with a question mark, any idea what might be causing that?

Excellent idea, thank you!!