Amscram
Mod is discontinued, use crackedvesselconfig instead.

I love this mod! Thank you for all your hard work.

This works partially in 1.19.x, but it causes a crash when the handbook is opened. Do you plan to update this for 1.19.x?

JACO1989 There is a class that has a chance to pick up cracked vessels, it's the Malefactor, pilferer trait: Pilferer (+15% drop rate, +10% rusty gear drop rate, 12% chance to collect cracked vessels)

I looked into it, it's caused by the "BuffedBlockLootVessel" class not registering for god-knows-why reasons.
How do I fix it? No idea, but now we know why it's causing issues. Work starts on that now.

EDIT: Net7 is doing some fucking bullllll with the
The type 'Dictionary<,>' is defined in an assembly that is not referenced. You must add a reference to assembly
so i'm going to have to revert to compiled for this release. Sorry. Just going to assume you're all here for the rebalance anyway.

EDIT2: In short, everything involved in this fix was flaming hot disaster, but at least I have a release out which (half) works in net7.

I have a problem with this mod, after trying to break the vessel, the vessel itself falls out instead of what's inside.

what should i do with this help

Winterdragon
They must have changed the way vessels work in the NET7 port.
Try to see if crackedvesselconfig works; using the values from this mod in their config.

Not working in the latest version for some reason, instead of breaking, the vessels just fall onto the ground over and over for any class. 

Heebeejeebees
The game does spoopy stuff with its multiplayer code. It's supposed to have singeplayer pairty, but it doesn't. Nobody knows why or how to fix it.
You should use CrackedVesselConfig as it does what this mod does properly while also giving you control over what you want the loottable to be.

So uh, hey when I drop a world into a server I created with this mod in any capacity, whether by itself with core mods or with others the vessels always drop itself when broken. If doing single with local server as provided in the game, I get my drops but when accessing a remote server my only drop is the vessel I just broke. Care to let me know what's going on with that? Am I doing something stupid?

DeNoven
You should check out https://mods.vintagestory.at/crackedvesselconfig as this mod does exactly what you want.

Ah, in that case I was correct - tool vessels have only been dropping flint tools! 
Also, no need to say sorry. I'd like if it had some level of configurability (just in general terms, 1x, half, 1.5x, 2x, etc) but it's your mod and I'll abide!

DeNoven
Sorry for nerfing the values in the latest update, they felt a little too high and made the vessels more annoying to open.
The way you can tell if the mod is working is by seeing if it drops obsidian tools instead of flint ones.

The mod files and folder come named "Uncompiled" and testing vs regular, seems to drop the normal, very meager levels of vessel loot. 
That said - the old drop rate seemed ideal; it was abundant but so extremely helpful that getting only a handful of items versus a good most of a stack seems bitter! 

Fixed for 1.18.0 and halved the total drops for the latest release, since the old ones still felt a little too overwhelming.
This does mean a few vessels have less drops than vanilla, but more than make up for it with a stronger loot table.
Also updated the item names for the few that were changed.

Caliber76
Really..? THAT'S the mod that's been causing the handbook to crash?
Thanks a ton I was wondering which one of my mods was causing that. Working on a fix.

please note this mod is currently unstable for 1.18.0-rc.2

Pamela
It takes the existing vessels and redirects the class file to a custom one.
So any changes to the vessel class file won't apply, assuming the patch still works, because I rerouted it to my own.

Will this mod work in 1.18 pre releases??

Unfortunately I don't know the first thing about compiling stuff like that.

DarkSlayerEX
Sorry I don't know a thing about how servers work.
You can always recompile the mod with your own code and see if that works.

I seem to be getting this error when trying to start a server using the uncompiled version of this mod.
It is causing all cracked vessels to drop themselves 100% of the time, and forcing me to go into single player to break them later.

Since the error seems to be pointing directly at a vintagestory DLL, I'm not sure it's related to any other mods. 

And yes, the VSSurvivalMod.dll file is in the mods folder.

[Error] [vesselbuff] Exception thrown when attempting to retrieve all types of the assembly kanbeji1, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null: System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types. Retrieve the LoaderExceptions property for more information.
at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
at System.Reflection.Assembly.GetTypes()
at Vintagestory.Common.ModContainer.GetModSystems(Assembly assembly) in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Common\API\ModContainer.cs:line 428, InnerException: . Will ignore asssembly. Loader exceptions:
29.1.2023 18:51:09 [Error] [vesselbuff] System.IO.FileNotFoundException: Could not load file or assembly 'VSSurvivalMod, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. The system cannot find the file specified.
File name: 'VSSurvivalMod, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'

Pamela
Theisgood

No problem sorry for not including it before. I forgot that text editors don't have the helpful API guide that coding platforms do.
Glad you were able to get things the way you wanted it. Let me know after playing with it if you prefer the new values. I might update the offical mod to have them.

Thanks man :) I gotta spend some time editing it but your guide here helped a lot!

That was very helpful and relatively easy.  I now have things just as I like.  Thanks for doing that.

Pamela
Theisgood

Change the class file as if it were a JSON. It's a very similar data format.
Shoot I probably should have added a guide on how to work this thing.

First you go down to Public class BuffedBlockLootVessel
BuffedBlockLootVesselt.lootLists["%vesseltype%] = LootList.Create(%tries%, LootList.Create(

Then each lootitem is a slot in the wheel, with tries being how many spins the wheel makes
For example, here is the first lootitem

I have no clue on how to edit the src file if thats what you mean.

I just want 1/4 of the drops I have opened the json file but its empty so I think you mean the src file needs to be edited to change the % rates.

I don't see any difference.  There are still no .json files to edit.

Re-released the mod in an uncompiled format. I will do this with other mods as I update them.
This allows people to adjust the code without needing to use a decompiler.
Yes, that means you can finally adjust the balance the way you see fit.

While my stance on people using my work remains the same (go ahead) this will make it more accessible to the average person.
You no longer need a decompiler nor a dev environment in order to change the code. Just open up a text editor and you're good to go.
JACO1989
Theisgood
Pamela

Sorry got locked out of my account due to some password fuckery. I'm back now.
I'm going to update this with a version which will be editable by players. Will likely do this with other releases as I update them.
Turns out you don't actually have to compile your mods. You can just have them as class files which will JIT compile at runtime.

No idea what will happen in the case of a mismatch between different versions. I'm interested in knowing what happens.

hello, would it be possible to make another mod like this, but with half of what is appropriate?

A config would be great!

My goodness its so OP at this current time, I am not going to complain but I got 100 flax from a vessel.

Is is possible to make a config so I can set it to 1/4 of the drops.

I am still going to use it but you can simply skip panning for copper easily.

Pamela
I shifted around the drop rates because the old ones clogged the inventory too fast

Something changed drastically in the newest version....I rarely get cattail tops anymore, mostly grass in the Forage vessels.  

Also, I have no idea how to "decomp the dll".....

Tels
You can rename the file on your end. I personally prefer just being able to drag and drop, overwriting the last version but I can see how that wouldn't be ideal for everyone.
Loot drops are decided the moment you break the vessel, so you don't need to reload your world in order to get the improved drop rates.

Thank you for the mod!
It would be good if the mod version was in the ZIP name like VesselBuff-1.0.3.zip - that way there is no confusion which version on is using on a server or in a client directory.

Do the new drops only affect  vessels in new chunks or also already generated vessels?

Pamela
It's hard coded within the class file. Sorry there isn't anything I can do to fix that.
Maybe another developer can come along and write some JSON code to make it possible.
However if you decomp the dll you can rewrite the class file to your liking.

I tried looking at the code, but couldn't find any .json files to edit.....

Completely redid the values of Ore to both reduce spam and balance rates.

Reduced the amount of rolls of Forage, Ore, and Arctic Supplied by two
This will make them less valuable, but way less annoying to open

I noticed that Forage (even with the rework) Ore and Arctic Supplies are a little on the excessive side.
From now on i'm making a policy; the average drop should fit within 8 inventory slots. If it goes over that, lower the drop rates.
Yes this means that some vessels will sometimes dip under 8 gears value but that's the price you pay for then not being annoying to open.

Pamela
How much do you want it toned down by? I really don't know how to make the drops any better without making them worth less.
There's also a lot of people asking me for a config not realizing that the mod literally essentially just a list of drop tables.
Sucks that the game has to hard-code it like that but there's nothing stopping you from forking the mod if you want custom balance.
It would probably be about as much work as writing a config since the mod is just a new class file for vessels containing the loot tables.

Still, the mod's relatively new so there's still lots of time to apply tweaks to get the balancing just right.
I think the Forage rework is a testement to how a few small changes can really improve the experience.

The drops are enormous!!  Can we tone it down, just a little, or give us a config file??

Ore vessels will now drop less lead and more copper
Forage vessels should be far less annoying to open now

Forage vessels will drop easily-stackable flax, grass and sticks more often, stones, clay and cattails less often.
Also dramatically reduced the chances and stacksize of beenades and poultices since they stack poorly.
To compensate this somewhat, the poultices have been upgraded to linen-sulfur-honey.
Flint has been upgraded to obsidian and stacksize reduced by 1/4, made rarer

In summary, you'll get less items overall, they will be of higher value, and a lot easier to stack.

It's OK you'll get used to having actually good drop rates eventually.
Kind of the issue with Forage is that they only drop junk, so it has to drop more to make up for it.
I would rather have them drop too many resources than not enough since you can just choose not to open them.
If I could find a solution which keeps the drop table mostly faithful while also toning down the item spam, I would go for it.

Here's a tip for dealing with Forage vessels: They drop a lot of cattails, use them to make baskets then place the loot in there.

This mod is not abundant, is way too redundant! I mean, ok, making vessels worthwhile, but there are also a lot of vessels around. Opening a single forage vessel gave many full stacks of items, that's way too much.

At the very least I would like a mod config file to tweak the amount I get.

Reworked Tool vessels to a different drop system because just a balance tweak wasn't enough:
You have a 50% chance of getting an obsidian tool (axe/knife/shovel)
You have a 20% chance of getting a copper tool (axe/knife/shovel/scythe/falx)
You have a 15% chance of finding an amount of rusty gears, averaging 16
You have a 10% chance of getting a bronze tool (axe/knife/shovel/scythe/falx)
The remaining 5% chance of scoring the illusive copper pickaxe

The copper pickaxe used to have a much higher drop rate but in large quantities it qualified as a 'booby prize' so its drop rate has been dramatically lowered to keep it sought-after.
It's about twice as common as it was under the old system so it's still a massive increase, but not so high that it prevents you from getting better, more worthwhile drops.