Interesting Ore Gen

Emu3008 It's not tested but I wrote the code with different world heights in mind. It should still work just fine but it isn't scaled appropriately for anything larger than prob 512 blocks in world height. (Again, larger! smaller is fine). To clarify it should work regardless of world height, the veins shouldn't stretch or deform any but they might be a bit small relative to scale on extremely large worlds. For the pictures, I've not gotten back around to working on the modpage unfortunately, at one point I had images on the page but because they were discord host images they disappear after a few days. Just haven't gotten around to hosting them somewhere else. As for the handbook pages, it's not something I've tried yet but I wouldn't mind adding a bit more flavor to the mod.

I've been on break from Vintage since about the mod's release, I likely wont be updating anything anytime soon given I'm quite busy irl. I set aside about 30 minutes a day to check the mod discord and DB page just to make sure any questions are answered. 😅

is this mod tested for worlds that have a world height higher than the default? also i think it would be neat if you could have visual depictions of the different generations as well as adding a brief description of the vein types in the handbook

Rodar It should. I've used it to 1.20.10 but I haven't tried anything beyond that I don't believe.

should this work with newer versions of 1.20?

GOODYOB Should do, I don't see why it wouldn't.

Will this mod work on 1.20.7?

Last I checked yes Dumb_Box I haven't personally tested the newer versions of TP but it should be perfectly fine. IOG should work with all landform and terrain mods.

does this mod work with terra pretty

badgerson
1.2.0 and 1.2.3 are only ore quantity changes, I mark these versions of the mod as completely stable and fully functional. There was a small issue, at the request of WatermelonFroggy for versions 1.2.1 and 1.2.2 where I tried implementing it so ore would only be exposed at certain depths, and my quick ad-hoc implementation wasn't up to my usual standard. I pulled those, so as long as you're using only 1.2.0 or 1.2.3 (1.2.3 has 50% ore gen chance) then you're perfectly fine.

I have also updated the Bugs and Issues page to reflect the 1 currently known issue with the mod, and I'm not really sure it's even from my mod because of it's inconsistency.

Richeeze
According to some posts from people in the TP thread it appears this is likely a Terra Prety issue, as it happens without my mod. What version of my mod are you using? And can you send me your worldgen log, and server.main log? Ideally through the official VS discord - IOG thread, it'll be faster.

https://discord.com/channels/302152934249070593/1367581350118428794

Hey so I am using 1.2.0 of this mod on a server with a couple of friends. Would you consider it experimental? Unbalanced? Buggy? Did i make a grave mistake? So far it seems to work fairly well, lots of tin in cliffs but that's not an issue for us...

Hello, from my current testing it seems that this mod doesnt work with the new Terra Pretty 7.0.2. When I load this mod, it just generates empty chunks. 

SubtleOrc 
I would enjoy making that a config, unfortunately the way I went about implementing it was ad-hoc and actually caused an immense amount of log spam. It didn't seem to cause any lag but feel free to use 1.2.2 and let me know if it works for you, it should still expose ore below a certain depth but keep everything above it hidden.

I just wouldn't recomend 1.2.1 or 1.2.2 IOG versions as they will spam logs. Again, no lag on my machine but it's also decently beefy.

"UPDATE:
Added a quick patch to make it so ore doesn't spawn in exposed caves or exposed to air. (Will still spawn exposed to water but this is a rare occurance anyway)"

Would be nice to make that configurable.. gives us more of a reason to go cave diving if we find some ore veins in it .. i know froggy and his server didnt like it, but i would quite like that in my single player world.

UPDATE 1.2.3:


Adjusted ore generation on all major metal ores and sulfur. Overall ores spawn about 50% less frequently than prior updates, except Malachite and Rhodochrosite. Those spawn infrequently to begin with and malachite is especially quite uncommon. (Plus it's my favorite ore :P)

Changed ore generation to only spawn ore (exposed to air) below 40% world height. This is based on absolute world height not on surface level. Assuming ground level is 50-70% world height, often you wont find ore exposed on the surface. This check ONLY looks for air blocks though, so you can still find ore peaking out behind tall grass! 😁 Often you wont find veins nearer the surface in caves though. My method for doing this ended up not working, and I didn't catch it in the dev environment. (I was a little rushed today) so this feature is, for now, put on the backburner and is NOT currently implemented

DO NOT USE VERSIONS 1.2.1 AND/OR 1.2.2


(Thanks again for Sky_StarBlade and others from the Age of Seraphs discord for the suggestion!)

Wahazar
Yeah basically it was on request from WatermelonFrogy, Worst case revert to 1.2.0 or don't use 1.2.1, no changes should have been made between versions.

Updating as well, post above. Thanks Sky_StarBlade for the suggestion, and some people from WatermelonFrogy's server, I implemented the world dependant issues.

Maybe ores could still be exposed to air below sea level? Like somewhere around 20 blocks below sea level or so? That way caving is still rewarding, but you don't get free easy surface ores?

I had basically begged for it in his DMs xD

Having them exposed made finding ore really easy since the veins were much more likely to hit a cave due to their increased size.

We've done probably too much testing on my server and even with 20% ore distribution it still felt like there was more ore than vanilla with 100%

You could always go back to the previous version because the only thing that changed in this was the exposed ore.

And it doesn't spawn when exposed to air

I also think I waas going to look at the possibility of making panning part of prospecting

There is already Pan and Prospect mod, where prospecting density is stored in gravel/sand when picked from given location (average used if mixed).

ore doesn't spawn in exposed caves or exposed to air

What is a reason of such patch? Cave prospecting was dangerous but rewarding thing in VS...

UPDATE:
Added a quick patch to make it so ore doesn't spawn in exposed caves or exposed to air. (Will still spawn exposed to water but this is a rare occurance anyway)

Wahazar
It's among the plans for the other sister mods. iirc (not looking at my notes) there's plants, water, protrusions of ore or other minerals, as well as physical landform depressions or laccolithic spires, and several others I'm forgetting. I also think I waas going to look at the possibility of making panning part of prospecting, or maybe using the prospecting pickaxe to break off chunks of stone and then panning the samples (after crushing) to get your ore concentrations, or something. That all would be total reworks of the prospecting system, as well as other types of generation I've not delved into and again is a very long ways out if/when I get around to it.

About indicators, I had idea to add plants as an ore indicators (geobotanical prospecting), where some plants may (with both false negative and false positive probability) spawn above deep ore deposits.

Unfortunaely it is not possible using just json, due to hardcoded 10 block depth limitation of surface indicators.

Wahazar
Actually that's how vanilla ore works, depending on distribution. Because of how I made my placement logic, I believe implementation of a distribution system like vanilla would actually be quite difficult with how I currently have things set up.
It was suggested to make ore veins have less "ore" in them through making the ore veins porous, something I might look into in the far future but for now the mod serves it's design goals perfectly, and I found it insanely frustrating in my testing of early versions of this mod mining ore that ended up being "fractured" as we don't have some sort of base material to follow like in real life. Normally you'll always see some sign of a vein (broken rock or a very thin layer of the vein, etc.), but in VS, because it's a blockgame, you can have fractured ore pieces away from the vein you'll have no indication of following. Eventually the plan was to use a tracer rock to define the vein (think quartz with Silver in Vanilla) but it ended up not really working the way I wanted, so we got solid veins instead.

Eventually, my plan is to implement 2 sister mods with this to make mining the interesting part of gameplay. The plan is to make it similar to TFC's support system, but with a bit of added flair and a few more interesting mechanics, make mining harder overall but more rewarding, and add a blasting rock system and then the 2nd mod is to remove the need for the prospecting pickaxe entirely and replace it with surface indications of veins beneath, such as finding a large sinkhole with a laccolithic dome at the bottom, or breccia pipe structures, large seams of quartz or faults of other mineralized and poorer qualities of ore, and probably even soil and water discoloration. These would give the idea there is ore under you but not where, so it would then be up to you to make mineshafts into the region and find the large, but rather hard to find, ore deposits.

These ideas are a long ways out, I'm on break right now from modding to work on some different projects and wont get back to it for quite a time. I can still post fixes and minor updates but nothing game changing. No exact ETA but I'd say probably 12+ months.

In contrary to TFC predecessor, where ores block were mixed with host rock blocks , VS ore generation is just plain homogenous, boring disc.

This mod add some interesting deposit shapes, but still 100% of ore spawn withing vein boundary. 

I propose to modify Banded generator to have probability of ore block spawn decreasing with the distance of the disc center - mining would be more interesting, with additional strategies (to dig more or not to dig).

Let me know how you like it and if you have screenshots of your mines or further feedback, feel free to send them in the Interesting Ore Gen mod thread on the Vintage Story discord!

IOG Thread on the Official Vintage Story discord.
https://discord.com/channels/302152934249070593/1367581350118428794

I played this game with 5 friends and we all quit at various points in time because mining for ore is absolute garbage in vanilla. I'm definitely going to try this and if it's anything close to as advertised I will be able to get the gang back together.🤠

SLEDGE_HAMMER Yeah that's a totally doable feature, although I wont be updating for quite some time (at least post 1.21 for VS) unless there is a major bug or feature lacking. Cinnabar is a mineral as well and I just didn't really bother with minerals truthfully. Sulfur is the only exception as I was testing it on a new oregen feature and just kept it in.

Would it be possible to make cinnabar spawn in hydrothermal-type formations near the surface? chimneys, hydrotubes, etc...

RosstheGreat Interesting! I'm not as savvy in everything as I'd like to be, or I'd offer my hand assisting with the patch without any hesitation. The only thing I do know, from what I've personally been dabbling with lately, is that load order issues can be rectified by setting dependencies. If the only issue thus far is that GA loads after the fact, have you considered, just for testing purposes, setting a dependency on GA for your mod, so it'd load after GA, or specifically separating the GA behaviors as their own separate patch, and then giving that new patch mod its own dependencies in the modinfo to IOG and GA? 

Of course, I'd be more than happy to help out testing or any of the more miserable legwork. I'll probably try to get in touch on Discord, in regards to that.

Zepper202 To give you a rough explanation, prospecting is unfortunately not absolute, but takes a rough value of how many spawn chances there are for an ore in a region, multiplies it by how much ore is in each deposit, and does some other math on it to give you your PPT readings. As my ore deposits are entirely random I generalize all ore deposits to have approximately 5000 to 7500 ore in it. You might have an area where your stone layer for that specific ore (hematite in this case) is super thin, and that's causing your readings to get messed up. However if that isn't the case, I genuinely don't know why you're having an issue. Hematite is the only ore in my mod that is entirely vanilla. I only make the deposits larger, and slightly less frequent. Otherwise it is the same generator that is built into vanilla.

If you're using Rock Strata Variety that can also cause issues with thin stone layers, I would recommend against using that mod, as most of my ores depend on thick stone layers.




Vigilance Truthfully I don't know what will happen if you combine the two, but what I assume will happen is you'll get GA ores in GA stone, and Vanilla ores in Vanilla stone. As per your example you wont get Native Copper spawning in Mudstone, although you might get Chalcocite spawning in limestone (or wherever it would spawn normally in Vanilla stones). That's because my mod only disables vanilla metal-ore generation, not the generation from GA. It would mean any and all GA ores spawn as discs where they should spawn normally, and there's a possibility of them spawning normally in normal stones too.

Also, it's not that I left GA out on purpose. I had actually written a patch for it, but it didn't work. For some reason registering GA stones in my mod causes it to crash, and the only explanation I can find is that GA loads after my mod loads, causing my mod to reference things that don't exist yet. It might require a totally seperate mod to work but that is a monumental amount of patching I'd have to do, and even then it's not totally guarenteed to work. The best solution I can find is having GA patch it in themselves as it would be easier and more stable anyway. If you want to do some testing or know much about JSON patching I'd be happy to have someone assist me on it as well.

IOG Thread on the Official Vintage Story discord.
https://discord.com/channels/302152934249070593/1367581350118428794

I think there still might be an issue with prospecting, at least for iron.

I started using the previous version of the mod before the prospecting bug was fixed. I prospected an area with very high hematite at the richest chunk, but after excavating several shafts down to the mantle I got no hematite readings. Eventually I used the block overlay mod to see where the ore was, but there was actually nothing in the entire area that was supposedly rich. I saw that the new version was supposed to fix prospecting readings, so I updated the mod, deleted all my old readings, and prospected the same area again. The chunk with the very high reading updated to an ultra high one, but again there's no iron in that area. Not sure if something's broken or I'm just very unlucky.

RosstheGreat I think that's a super valid reason to axe GA, and cut it out of the initial scope/focus. Unfortunately, as far as my "group" goes, I'm the rockhound, so... unfortunately... :)

I couldn't particularly imagine a world I don't have my obtuse quantity of extra rocks and minerals, even if it would lead to a lot less headaches overall for me when it came to... Well, all manner of things, but mostly mod compatibility. I'm just worried, because if I had to rely entirely on GA's ores to populate GA's rocks... I guess it depends what that'd mean? Like, native copper discs not generating in, say, mudstone? Naturally I'm not expecting it to just magically spit out Chalcocite veins in your mod's fashion, or even for native copper to generate in GA rocks by your mod's methods, but my interpretation meant ore gen would get very silly in an undesirable way should I jump the gun and throw the mod in as it stands.

Vigilance Because to get my new oregen to work I decided to patch vanilla ore spawn to 0. This is to prevent accidental overlap, but also because if I were to patch my new JSON modifiers into the vanilla oregen it would flat out cause crashes with other mods. This was the safest way to run it. I'm almost certain you can run IOG and GA together, they just wont interact at all, but also shouldn't crash or cause any errors. Hopefully.

Also, I stopped using GA a long time ago mainly because it bloated the ore pool too much. A lot of the people I run with in my server ended up disliking having so many different ore types (most of them aren't "geology savvey") so chalcocite and chalocopyrite giving half the ore ended up being more annoying than immersive for most of them. I still love GA, and I think it'd be really cool to add back on my server some day but for now I must remain with the vanilla ores on my server.

Out of curiosity, why does this mod break vanilla ores within GA stones? I was thinking about it, and if it just left the old ore gen for their stones and used yours for vanilla stone layers, that'd almost be tolerable to use it as-is until a GA patch came. On the other hand, it's probably just better to wait for a proper compatibility than bargaining and making compromises. Lol.

I'm still very excited about this. In an alternate universe, maybe my next server will do away with GA just to try this oregen out. Fantastic idea, and it brings me a lot of joy to see attention to detail being paid to systems like this.

Alright, thanks for the info, RosstheGreat.

I appreciate the clarification! Hope everything is situated now! 😄

Alright,this error has nothing to do with your mod,i just touched some configs i shouldn't have 😅

VladTheG Interesting... I've never had any error like that whatsoever, can you send me your server.main and your full modlist? It would be easier over the discord to help, but for now try just using my mod (No other ones) and load the same seed in a different world.

I run a modpack of 190+ mods and while it can be laggy at times on my pc, it never has caused me this issue.

I realy liked this mod from the desriptions,but now i'm trying to create a new world to play with it,and i'm getting an error:

Exception: Somehow worldgen has become stuck in an endless loop, please report this as a bug! Additional data in the server-main log
at Vintagestory.Server.ServerSystemSupplyChunks.loadChunkAreaBlocking(Int32 chunkX1, Int32 chunkZ1, Int32 chunkX2, Int32 chunkZ2, Boolean isStartupLoad, ITreeAttribute chunkGenParams) in VintagestoryLib\Server\Systems\World\LoadThread\SupplyChunks.cs:line 1793
at Vintagestory.Server.ServerSystemSupplyChunks.InitWorldgenAndSpawnChunks() in VintagestoryLib\Server\Systems\World\LoadThread\SupplyChunks.cs:line 1537
at Vintagestory.Server.ServerSystemLoadAndSaveGame.OnWorldgenStartup() in VintagestoryLib\Server\Systems\World\LoadThread\LoadSaveGame.cs:line 198
at Vintagestory.Server.ServerEventManager.<>c.<TriggerWorldgenStartup>b__112_0(Action dele) in VintagestoryLib\Server\ServerEventManager.cs:line 448
at Vintagestory.Server.ServerEventManager.Trigger[T](Delegate[] delegates, String eventName, Action`1 onDele, Action onException) in VintagestoryLib\Server\ServerEventManager.cs:line 718

I have way to many mods,but i've played with them for a while,and the game was semistable,and this error appeared after i installed this mod

Froshure Changing the global deposit spawn rate should reduce overall spawn rate, but I haven't done extensive testing on it.

I assume you mean on a block-for-block basis. How many blocks of ore does my mod spawn compared to vanilla, and the answer should overall be "less" but it's hard to tell you for certain. If you're asking on a "per deposit" basis, the answer is  substantially less than vanilla, but I make up for that by making the veins overall much larger.

I want to add, though, this is purely from my testing. I have no hard evidence for one way or another, but I tried to create something less matching vanilla but more for the design concept of "Large but somewhat rare deposits" with the addition of "establishing infrastructure for your mine".

Does changing the "Global deposit spawn rate" option in world generation settings affect this mod?

And with this mod, how realistic would you say the quantity of ore generated is?; is it more, less, or about equal to the quantity of ore generated in vanilla VS?

This seems really interesting! Will definitely try it out on my new server ♥

I'm happy you like it! I'm incredibly pleased with how the mod turned out. 😄

This is incredible and I love it, thank you so much!

Mollycoddle You shouldn't need it, no, none of my ore veins are sea-level deterministic.

Just want to check, if I'm using this I don't need the sea level fix mod, right?

Undea It shouldn't change terrain form at all, it only changes deposit generation. I don't think there will be an issue but make a backup of your world first! I'm not familiar with WorldgenFix, but if it doesn't mess with ore at all then it should be totally fine.

hi,

if you use it in an old save, how does the border from old to new look? could we get the ugly line, between old and new terrain?

and i have a 512 world with WorldgenFix how is the compatibline there?

Jalex All new ore shapes can spawn in newly generated chunks. If you started a new world recently it shouldn't be too big of a deal, you maybe have only explored a few thousand blocks. Just update the mod and any new veins should generate in newly formed chunks, and I apologize for the update spam, I had finished the previous update and when I started talking to the GA devs it reminded me I had a generator I needed to finish and I also needed to get sub-deposits functioning. As of current this should be the last major update for a long time.

Jomeaga I tried my best to reach a happy medium for most people. Some people will want a single deposit every thousand blocks, and some will want a dozen per chunk (exaggeration but you get my point), if you want less spawn rate it's very easy to unpackage the mod and drop the spawn amounts in the JSONs, I'm happy to explain it in detail if you're interested! If you find an amount you like I am happy to make a "Hardcore" patch mod for it as well for others to use. I tried my best to make the spawn rate sort of match vanilla ore density, but unfortunately I'm able to test this only so far on my own.

Do the new Ore Shapes generate on already existing saves, or do I have to start another one ... again lol

I love this mod, mining is my favourite part of the game and I've been waiting for something to make it feel more worthwhile to setup a mine! However, I think the generation chance is currently way too generous. Even set to 20% spawn rate, there are tons of deposits of thousands of blocks of ore...

Updated!

Looks promising! The only thing stopping me from trying it right now is compatibility with GA.

Updated!

Fixed the prospecting bug, found the reason and all should be well now. You'll notice much higher concentratons of ore in an area, as average deposit amount per chunk has vastly increased when you're near an ore vein!
Also decreased silver spawn rate by approximately 25%

ShyishHazard I agree, I actually had intended to include some patching to the cavein code when I first set out to create this mod, and ended up going through with it in testing! However it ended up making mining so unpredictable because supports don't really work ingame. Highly recommend the "Post and Beam" mod though even for just the looks!

Tyan Indeed! The intention is harder to find veins but once you do the mines will almost require infrastructure to be set up! And, as for the sea level/mountain generation I purposely left a few ores in high spawns to get "horizontal" mines as opposed to ladder vertical mines. I want to use Rust and Railroads in my next personal server so I made sure we'd get some mines like that.

love the new ore vein shapes and this is amazing since it makes setting up an actual mine to work a specific vein (rather than just endlessly digging shafts and prospecting smaller veins) possible.

I'd love to see more above sea level ore generation so that mountains and large scale hilly areas have more ore. Lots of ore is still far down below sea level.

some of these formations would certainly make mining more interesting, the current disc-only situation makes playing with cave-ins enabled a relative non-issue

As soon as this gets a Geology Additions patch, I'm going to give myself nightmares grafting it in to my ongoing world. This looks very on par with what I've been wanting.

Shion I totally feel that! 😓 I have started several worlds because I found a new mod that added new generation of some kind and wanted the ability to play with it sooner rather than later! The woes of selection! hahah

Mods like these make me want to start a new world every time, which is why I never got to the steel age >_<

I was unaware EM changed ores? Haven't tried it, but I'll look into it.

Edit: Looked into it, from a very light search it doesn't appear I effect any of the ores it's patching, it should be 100% compatible.

Does this work with Expanded Matter/is any compatibility planned? EM's ore changes are pretty miniscule, but they still exist.

Aloy
Yes, this should work with all standard world gen mods! 😄

does it work with other world gen mods like vanillaplus worldgen?

this looks great, looking forward to geo additons so I can yolo this into my existing world =D

HaraiseTenshi The bug only effects the output % number, I suspect it's because the ore concentration is technically way less than vanilla per chunk. I did notice in very dense areas in my testing it will bump up the percent (for example 0.01%%). The readings are still accurate, but I also haven't tested this extensively yet. And, again, I'm not really sure why this is happening.

Basically, if you ignore the numerical output it should still give you a good chance of finding ore. I am hunting that bug best I can though! 😅

Geology additions is not currently integrated but it should work with vanilla ores in vanilla stone. I just haven't gotten the energy to write a patch for Geology Additions yet truthfully!

If the prospecting bug can be fixed I am so gonna add this one :)

This is pure mad genius!

 my god, this is exactly what I wanted. Small Question, are you planning to also add Geology Additions Extra Ores to this?

That looks absolutely amazing. Do you know if it happens to work with Geology Additions?

Excited to see this, it's exactly what I've been looking for out of the game. Can't wait to try it out!!!