"This mod attempts fix both of these bugs. It will only impact new generation and will not fix chunks that were generated before the mod was installed."

So if I use the /db prune command to delete the chunks in an already loaded save, would it work?
I don't know if I explained it well.

MadSeraph

PeterSanderson

I did indeed have Rivers installed and enabled.

Junrall I don't suppose you had Rivers on when you tested with Terra Prety by any chance?

ElusiveEnigma

I use this with Terra Pretty... works perfectly!

ElusiveEnigma

Mods that work with vanilla worldgen systems, often called "landform" mods, such as Conquest, Terra Prety, Plains & Valleys, etc should work just fine. In fact I did most of my testing with Conquest running. Ones that modify vanilla worldgen code such as Rivers or Alpine Story, however, have the potential to conflict. I have not tested with any of them, so I can't tell you for sure.

MadSeraph

To your knowledge, is this compataible with worldgen mods or do you have reason to believe there could be overlapping conflict?

Yes, point 2 is very valid. I'm also often wary of mods that claim to "fix" things, often fixing things that aren't actually broken, or fixing it in ways that aren't proper - which can cause other issues. So far though, after some testing, this mod seems to work very well. I can find many surface bits again when traveling at 320 world height.

As for the clay, I guess I'll leave that be for now until the devs rebalance it maybe. Unless it's their intention to have it this rare / barely visible. I guess if you're lucky you might dig into it when looking for ore. Red clay can be found but it's definitely harder to find than blue clay in 1.19. It's a bit of a shame because this of course nerfs clay working as a whole, and consequently mods that expand on that.

DarkThoughts

1) Blue Clay seems to be working "as intended". It only generates at exactly sea level (using the right value even without this patch). It only attempts to spawn 1 in every 250 chunks (vs red clays 1 in every 52). So that low random chance to attempt a spawn has to just happen to try on a block sitting right at sea level. Often those blocks are sand blocks, so you often only end up with half a disc that forms in the dirt behind the sand but _under the surface_. It is _exceptionally_ rare. I don't know why the devs did it this way, but they did.

2) Yes, I have reported these and submitted pull requests on github as well. I have also discussed the issue extensively with one of the devs on Discord. They are aware of the issue, and I'm hopeful it wll be fixed soon, but possibly not before 1.21. Devs are rightly wary of fixes submitted by outsiders. They need to be extra sure my fix works and didn't inadvertantly break something else, and they have much bigger issues to deal with right now. Honestly, I'd prefer they spend their time on desyncs that cause items to vanish when moving between inventories before taking the time to look at this. In the meantime, this issue was particularly itchy for me so I fixed it and made it a mod so I can run it on my server. :)

3) Mods that add their own ores should benefit from this fix. The issue is specifically with deposit configurations that use 'generator: "disc-followsealevel"' in their json configuration.

Droseran

Yeah I've seen your mod and have a tab open for it for consideration. I'm just curious whether it actually is a bug - specifically with increased world heights or different worldgen than that of vanilla, simply intended, or just badly balanced in general. There's definitely been an issue with ores, because I've never had this much trouble with finding surface copper before. It's pretty common normally, just often well hidden by shrubs and other foliage. Clay on the other hand was super common before, at least in wetter regions I found patches very close to each other. Since the update I only found a few very rare red clay patches (one of them in a dangerous mountain side since I play with soil instability) and only one blue clay deposit. Given how many test worlds I do where I just explore around to get a feel for the worldgen mods & settings, I think it's incredibly rare at the moment.

DarkThoughts

I've made a mod to increase blue clay generation (https://mods.vintagestory.at/show/mod/20343). I think it's just been made ridiculously rare, as it has a spawn rate around 2/3 of red clay on top of the new rigid spawning constraints.

Lightpowder

Check the wiki. VS has commands to regenerate chunks. Just be careful and create a backup first in case you accidentally regenerate parts of your base.

Ah, so that's why I could barely find anything on our Conquest Landform Overhaul (with the mod's recommended settings ofc) world huh...
Shame that it requires either a remaking a world with the same seed or a new world, but it's completely understandable.
We'd probably use it later, when Wildcraft gets a new module cuz we wanna remake our world and copy important chunks when that comes out.

Oh my fucking god... I thought I was going crazy with the lack of almost ANY surface ore nuggets anywhere. Some questions though:

1) Could you check if there's a similar issue with blue clay? I use Conquest Landform Overhaul for the worldgen and it seems excessively rare now, even at sea level height on worldgen that recommends 320 world height.

2) Is this reported on the actual VS issue tracker so it can get properly fixed instead of modded band-aid solutions? No disrespect btw, I just don't think it should be a mod's purpose to fix bugs. This should not end up like Bethesda where the developers let the community take care of bug fixing instead of doing it themselves.

3) Is this based on code issues with the individual ores themselves or how the game handles ore spawns in general? I'm asking to understand whether mods that add their own ores, such as Geology Additions, would be affected by this bug or not.

following this! i always love playing with a larger world height, makes adventuring all the more fun but i NEVER find borax or black coal.

DUCATISLO I'm sure it will be. It's been reported. I made this because I want to run a server with a 320 world height, and I wanted working ores. :)

i think this should been an official fix tbh