The update fixed the problem for me. Happy to help. :)

Yeah I got the server-main log error too, it also crashed my game. Thought it was a one-time thing so I didn't bother reporting it. Will update accordingly.

Kathanon

Thanks for the feedback, hopefully this new release solves the issues you mentioned. I've also cleaned up some of my lazy code and added localization thanks to your help!

goated 

My server-main.log is filled with errors (see below) from this mod, to the point that the game closed with the message "Too many errors detected.".

The cause is that Vintagestory.GameContent.BlockDamageOnTouch.OnEntityCollide does not set DamageSource.CauseEntity, so dmgSource.CauseEntity.Class in your code generates a null pointer exception.
Changing it to dmgSource.CauseEntity?.Class should fix that issue.

Additionally, the call to SendMessage is after the end of the innermost if clause, which will cause similar errors whenever the cause is not a player.
I'm guessing that is a mistake, and that you meant to put it inside the inner if.

Exception:

[Error] Exception: Object reference not set to an instance of an object.
at OutgoingDamageLog.OutgoingDamageLogModSystem.OutgoingDamageLogPlayer(Entity __instance, DamageSource dmgSource, Single damage) in C:\Users\Heath\source\repos\OutgoingDamageLog\OutgoingDamageLog\OutgoingDamageLogModSystem.cs:line 32
at Vintagestory.GameContent.EntityBehaviorHealth.OnEntityReceiveDamage(DamageSource damageSource, Single& damage) in VSEssentials\Entity\Behavior\BehaviorHealth.cs:line 209
at Vintagestory.API.Common.Entities.Entity.ReceiveDamage(DamageSource damageSource, Single damage) in VintagestoryApi\Common\Entity\Entity.cs:line 851
at Vintagestory.GameContent.BlockDamageOnTouch.OnEntityCollide(IWorldAccessor world, Entity entity, BlockPos pos, BlockFacing facing, Vec3d collideSpeed, Boolean isImpact) in VSSurvivalMod\Block\BlockDamageOnTouch.cs:line 54
at Vintagestory.API.MathTools.CollisionTester.ApplyTerrainCollision(Entity entity, EntityPos entityPos, Single dtFactor, Vec3d& newPosition, Single stepHeight, Single yExtra) in VintagestoryApi\Math\CollisionTester.cs:line 197
at Vintagestory.GameContent.EntityBehaviorControlledPhysics.ApplyTests(EntityPos pos, EntityControls controls, Single dt, Boolean remote) in VSEssentials\Entity\Behavior\BehaviorControlledPhysics.cs:line 256
at Vintagestory.GameContent.EntityBehaviorControlledPhysics.OnPhysicsTick(Single dt) in VSEssentials\Entity\Behavior\BehaviorControlledPhysics.cs:line 491
at Vintagestory.Server.PhysicsManager.DoWork(Int32 threadNumber) in VintagestoryLib\Server\PhysicsManager.cs:line 592

Ket

It will work fine in vanilla. It was made for CO because CO has more complex mechanics for damage, but it will function fine in vanilla. Even if it doesn't work with how a mod is implemented, it shouldn't break anything.

Is this meant to be compatible with vanilla as well? If it's not it is a good idea to add combat overhaul as a dependency in the modinfo

Kathanon

Thanks for the input, I might see if I can add localization tonight and push out a new release. I also want to try adding configs and things like that to make it more tunable, as this mod is really designed for multiplayer servers.

DejFidOFF 

No, this is strictly so a player can see how much damage they're dealing to an enemy they're hitting. It does not record that information anywhere in a file or in the server log beyond what Vanilla does.

Since you said you don't know how to do localization, here's how:

• Add a file assets\mod_id\lang\en.json, containing a json dict (the one in curly brackets).
• Populate it with with one key/value pair per string you want to localize, with both key and value being the English version of that string.
  • Example:   "some_string" : "some_string",
• Wherever you use the string in your code, replace "some_string" with Lang.Get("mod_id:some_string")
• If you want to insert a value into a string, then you add {0} in the string in en.json, and pass the value as the second parameter to Lang.Get.
  • If you need several values, then use {1}, {2}, etc.

Replace mod_id and some_string with appropriate strings.
Technically the keys can be any string you want, but if there is no localization for the string in the active language, then it uses the key instead, so using the same string gives you English as default.

This is not to push you to localize it, I just want to help a fellow modder. :)

DessertOverlord

So how it works? When I put that on the server it will track and log of all players / entities damage?