confirmed, thanks. i'll get it fixed -eventually- along some other thingies. probably when the actual 1.22 release happens.

Hi having an issue on 1.22rc-10 where the Temporal Rifts are invisible disabling this mod fixes it. There could be an incompatbility on my end. but I can't exactly tell. Thanks for the awesome mod.

Chrius

thx for reporting. just a very minor issue in the configlib patch. fixed for next release.

Every time I load a game (on 1.22-rc2), I get an error: "[Error] [Config lib] (darkvision) Error on parsing config: System.ArgumentException: An item with the same key has already been added. Key: [6.9, ConfigLib.ConfigSetting] at System.Collections.Generic.SortedDictionary`2.Add(TKey key TValue value)" The mod does work, but I don't have any options in DarkVision on the Mods Settings window.

FujjKup

it's a simple shader issue. i can release a fixed version in no time by just updating the shader, though i would much rather prefer to pre-release a version with the runtime shader patching thing for testing which is still ways to go. maybe tonight, maybe in the coming days.

furthermore, the changes they have done to the vanilla shader is marked as experimental, meaning that next release could just break whatever version i release. the runtime shader patching would not have this issue.

As of rc.2 the lighting blowout for held light sources mentioned by Madalovin is still very much present, as I'm sure you are aware. However to add to that I tested several (not all) config values and none of the more obvious settings seemed to help with it. Love the mod and eagerly await any updates when you find you have the time :)

Madalovin

there is a fairly extensive config. read the description to see how to edit it.

I enjoyed your mod for while it worked for a whole night, heheheheh.
I like how your dynamic adjustment works, it functioned better than I could've anticipated.
The process of adapting from bright to dark works in a pleasin' way. c:
Do you have pans to include some configs for tweakin' it to the users content later?
edit: Sorry for not reading the full contents of the description.

Madalovin

yeah i noticed there were changes but i have not tested or checked whatever changed. i'll get around to it eventually.

don't expect a release for rc1 versions. i'll release a proper hopefully finished version when stable hits.

unsurprisingly, this is exactly why i need to implement a runtime patching system for shaders. it's gonna be a bit of time.

Playing in Vintage Story 1.22.0-rc.1
With the latest change of "Tweak: Held/dynamic light range now better corresponds to placed light range (experimental!)"
The change in how the lighting works is.... uhhh.....   Here are screenshots.

grammer edit

Loving this effect, this'll be a keeper for as long as it works. :)
At time of typing, this works in 1.22.0 prerelease 4
Now part of me is wondering if we can get away with a eye patch add-on for the functionality of having one eye pre-adjusted to the dark, hehah.

ChaoticNox

it replaces the same shader file I replace to boost the light. so it's fundamentally incompatible with darkvision until i manage to figure out a way to patch shaders at runtime instead of overriding them. (and even then, i will probably only patch them for the 1.22 version)

i think why it works outdoors but not underground is probably due to the overexposure effect boosting light a bit.

Cheeki I found it! Somehow the mod Better Jonas Device Fixed (https://mods.vintagestory.at/betterjonasdevicesfixed) was causing the issue. I'm not sure why but my guess would be that it changes the night vision mask perhaps? 

ChaoticNox

probably some odd incompatibility. are you running other shader mods?

is your dynamic light count set to 0?

Cheeki I did try to hold a light source and then putting it away. I tried to max the settings to make it brighter and it worked only on the surface, I might have something interfering it wouldn't surprise me if that's the issue since I have a lot of mods running.

ChaoticNox

the mod works both underground and above ground at night or in dark enclosed spaces. there is no check that differentiates between above ground and underground. yet.

please tell me more what you are doing, are you holding a light source in your hands?

Is the mod not supposed to work underground? It works above ground but whenever I get just deep enough it's absolutely pitch black and I tried to also have a source of light nearby but still nothing.

PunisherLex

Once again, I disagree with this addition for various reasons and don't consider it worthy of my time.

I will add it only so people can stop asking about it. disabled by default. raycast check straight upwards for sunlight and collision to roughly determine if you are outside or nearly outside. will deadapt using normal timer. don't report false positives. next update.

Is there any chance of an update to the configs in the future to allow the brightening effect to obey a block sunlight level threshold pulling from the debug menu to more closely imitate irl low-light vision?

The mod's a great QoL addition but currently it feels cheaty as it works in caves even when they are completely without any chance of light reaching the blocks, completely invalidating torches in caving outside of spawn prevention utility. Especially since Human low-light vision in the first place requires at least some light to work (Source: I Have a completely windowless and Isolated bathroom in my home, I can assure you from bumbling in there after waking up at 3am, adjusted eyesight doesn't work in there if I close that door)

Please refrain from clogging up the comments with unnecessary drama. If you cannot accept that a feature request might be denied, it would be best not to comment at all.

Rhaenya They can speak for themselves. Quit being a white-knight. It's embarrassing. 

Maoman
If you want all those features then go ahead and make your own mod. Don't complain when mod author doesn't want to implement something in their completely free to use and download mod.

OddMekanism

very curious. well since using a quad instead of triangle fixes it, i'll add a compatibility option in the config next update...

if you want to use the latest version of the mod in the meantime, i reckon deleting those 2 shader files should fix the issue (but you lose the overexposure effect)

Cheeki

Okay so, the 1.1.0 version doesn't have any problems seemingly!

Altering the code block of the 1.2.1 and 1.2.0 versions doesn't get rid of the quadrat, but both do change change it to this: [image]

I also tried the 1.1.1 version after the Nvidida fix. Interestingly this one has even more quadrats within the quadrats AND the smoke particles from the torches are rendered incorrectly as square outlines: [image 2; It's quadrats all the way baby...]

Cheers!



P.S. As an aside - just in case it's helpful - I noticed seperately (not tied to Dark Vision mod) that the rendering for the Footprints mod is also incorrect, preserving scale and opacity of the footprint layer but not managing to render the image, just the (bounding box?) they're in.

OddMekanism

that is curious... it's probably some "antique hardware" issue...

does it happen with 1.1.0 version of the mod? that one used a quad to render the exposure effect instead of a giant triangle.

also try 1.2.0 or 1.2.1 (depending on your game version), open up the mod .zip, navigate to /assets/darkvision/shaders/darkvisionfx.fsh and add on top of "vec4 color ..." this

vec2 clampedUV = clamp(texCoord, 0.0, 1.0);

then replace vec4 color with this:

vec4 color = texture(primaryScene, clampedUV);

the end result code block should look like this:

vec2 clampedUV = clamp(texCoord, 0.0, 1.0);
vec4 color = texture(primaryScene, clampedUV);
vec3 originalColor = color.rgb;
outColor.a = color.a;

if this doesn't work, deleting the darkvisionfx.fsh and .vsh should work. you'll be missing the overexposure feature though.

Hi there!

Reporting an issue with rendering that I am fairly confident is an issue with my old hardware and drivers rather than anything else, but still...

When playing I get an infinitely repeating duplication of the game window in quadrants in the top right corner:

[Image]

I vaguely remember something like this happening when modding Skyrim or Minecraft with some shaders waaaaay in the past, but I can't say for certain.
As far as the game runs, it seems to be fine otherwise. Tested on the current testing version and the previous version [1.21.6] and the issue was NOT present on my more modern Win11 laptop with integrated Intel Iris grapics & current drivers.


System specs:
Processor - Intel(R) Core(TM) i5-4690K CPU @ 3.50GHz 3.50 GHz
Installed RAM - 8.00 GB
Graphics Card - AMD Radeon R9 200 Series (4 GB)
System Type - 64-bit operating system, x64-based processor
OS - Windows 10 :')
(drivers are as up to date as they can be but still quite old...)

Oh okii good to know ! Good luck with patching that !

Vari_Ares

yes. i figured since the drug shader is not screenspace but world space (it applies on blocks, not the screen) that they just put the drug shader into the chunk shader code. I do the same thing too, but for desaturation. hence why this mod overrides shaders.

there are also some other shader changes that are not drug related that are addressed too.

Don't worry lol ! Out of curiosity how did you knew that issue that fast too ? xD

Ty ! Okii !

Vari_Ares

thanks. i already fixed that in a new build but i did not push it since i did not think people would be interested in playing a pre release version lol

i'll upload a working build in some hours.

also working on a way to not override shaders so issues like this can be avoided in the future but it's not ready yet.

Hi ! Ty for your mod I like it ! But just an issue with new 1.22 update : the "drug" effect while eating some of the new mushrooms doesn't work with your mod ! So at least you know (if you can fix that)

1: so that's a no then
2: "the realism makes sense, but no."
k.

Maoman

1. maybe
2. no. it is meant to boost pure darkness. you lose your torch in a cave because you jump in water or whatever, you get some adaptation to get out or continue exploring. the realistic approach makes sense but i don't think it's neither worthwhile implementing nor an interesting thing to have. the game changes music based on sunlight presence. there is no "cave detection system", and i have no interest in implementing one.

I really like this mod, especially the deep customization available. Two suggestions:

1: add a setting that limits how much your adaptation gets ruined by looking at a light that's out of near range but within max range. My night vision is not going to be completely 100% ruined by looking at a distant source of light no matter how long I stare at it--just mildly reduced. Until then I'm just setting max range way shorter than intended because I want to be able to look at my house from across the river and such without losing night vision. 

2: The game already detects when you're underground versus outdoors somehow because the music changes. If you can hook into that system, it would be super cool if the night-vision applied while outside (in moonlight) but did not apply inside caves (where it would be completely pitch black). This would also help with ThePerfectLink's concern about light level 0 boosting. It does make sense at night--the light level is technically zero, but realistically there ought to be moonlight to see by, but in caves, the light level is zero and it should feel like zero. You only get the light you brought with you.

hey @cheeki im currently making an armor mod and lookng into how your mod functions mine is more of a rust rot vision but new to shaders can I possibly look into how your doing some things on a code level and maybe adapt and mod it to my uses would save me weeks im guessing as im 3 months into shaders and feel dumber than whe I started..... but if not i understand and ill find another route not asking to use your code just kinda see how it works for my own purposes but don't want to step on any toes that would be mean.

Not bad, however the default is way too strong, and there is no brightness level minimum for when your character's eyesight should unadapt, just a maximum. In other words, my character shouldn't be boosting the brightness of his retinas at light level 0, but that might be a decent stand-in for night vision at light level 1.

captanredbeard

fixed. thanks. the issue was i forgot to write the default config on the server if missing. so it just spam that it creates it every config reload check but it actually doesnt.

i didn't catch it because configlib was on the server and that would handle config creation.

Cheeki

Have a Logspam about config.

CycloniumGame

ask seraph leveling's author for support. the relevant stats are exposed.

Cheeki yes i would like to gain some darkvision while spending time in the dark 

CycloniumGame

elaborate, is something not working properly? do you want to gain some darkvision related trait while spending time in the dark?

traits/stats can be changed (currently only if playermodellib is installed, not a hard requirement, just needs further testing atm) by mods. it's meant for race/class mods.

is there anyway to make this compatitible with Seraph Leveling?  

Ironscale AstralDragon

Cannot get to reproduce it either with immersive lantern.

Does this happen with the previous version of darkvision? 1.0.0? The shader on that version has its own issue of flickering rift portals due to bad render order, and that is what is changed in the current version. Might be that.

Care to share your GPU, out of curiosity? I am testing on both windows and linux with an AMD card.

Edit: i have confirmed this is an NVIDIA specific issue. fixed in upcoming update

Might test this a bit further out of interest, but I can confirm that I do not have Immersive Lanterns.

I was just noticing the same issue as mentioned a bit below my comment. This effect is 'very' visible with SaltyWater's Immersive Lanterns (Torch specifically) due to the flickering effect IMO. Perhaps, if the user experiencing it below also had Immersive Lanterns, it could be just bluntly tied to that in some way. Its even funnier because I was just about making a comment on Immersive Lanterns before I realize its probably due to Darkvision in some way more directly for why it fades in and out.

To outline what happens, you get your darkvision adaptation, and then you pull out the torch, and you'll likely notice the seam across your vision diagnally. I might test it without any other mods but right now I'm running a coop set up thats kinda messy with my personal save's mods so reluctant to be disabling and reenabling mods right now while we're doing a little bit of exploratory testing of certain things we've noticed.

Cheeki

Seems like it was, indeed, something to do with the exposure effect - Turning that feature off by setting exposure multiplier to 0 fixes it.

And yeah, probably whatever's going wrong here is specific to my setup. GPU hasn't given me any other trouble like this (or at all), but GPUs in general are also powered by evil wizard magic BS so it's impossible to rule out.

Either way, thank you for pointing me in the right direction!

Ironscale

I cannot reproduce the issue in any way...

Please check if it happens with only this mod enabled in a fresh world. If yes, try turning exposure-multiplier to 0 and trying again. If it still happens, open the mod zip folder, navigate to /assets/darkvision/shaders/ and delete those two shaders there and restart the game. They control the exposure effect and it's a fullscreen quad, which would fit with the "diagonal line" symptom. If that solves it, it tells me there is some kind of issue either with your GPU... which could be a myriad of things, or it's some issue with how the shader renders (somehow specific to your game? maybe some other mod that adds some overlay?) 

Cheeki

• It's 100% consistent with dark vision turning on. I have not seen it happen in any other context.
• Disabling desaturation didn't affect it at all.
• Only shader-related thing I have is XVshaders. I tried turning that off, but it didn't seem to make any difference.
• This effect is always in the exact same place, and it doesn't seem to interact with block selection. It's like there's a transparent filter/overlay on the screen.
• It's a diagonal-ish (It's not a clean diagonal, the edge is jagged, the top edge of the screen is also included, and there are some glitchy looking flickering squares separate from it) separation where the bottom right "half" is darker. The effect is only really visible when looking at brighter textures - E.g., if I stare at dark rock or into the night sky, it's basically invisible. The closest thing I can liken it to is that it's almost like if you had a perfectly clean diagonal overlay/filter that was supposed to darken the bottom right side, but it was saved with really bad image compression that messed it up.
• Yeah, these comments only allow super-small images, sadly. I tried uploading to an image host, but the links always get culled as well.

I did notice that resetting the maximum brightness to default effectively stops it from happening because the textures never get bright enough for it to be discernible. However, even then, I can still see that the overlay effect is there if I go looking for it - E.g., if I have full dark vision but I put a lit area in the top right corner of my screen.

Ironscale

curious. is it intermittent or is it consistent with dark vision turning on? can you check if by disabling desaturation (turn strength to 0) it disappears?

any shader or graphics mods? anything more you can tell me about it? is it always in a fixed position or does it extend from the block selection overlay?

looking at the image... do you mean the literal diagonal line separating "lit" from "unlit"? a bit hard to interpret xd

Getting this extremely odd diagonal "overlay" effect/artifacting when the dark vision turns on.

I doubt it's this mod's fault in any way, but if anyone else sees this and figures out why it happens, let me know, because as of now I'm stumped.

thinks for saving the time it would have cost me for divin,

lechkingofdead

supported. you just have to add the relevant item name in the config.

i'll save you some time and tell you that it's walkingstick:walkingstick-lantern that you have to add to darkvision-arrays.yaml, in the light-sources array

ground placement doesnt get detected though. i'll have a more universal solution for that in some time.

given im the miner/caver of my game (dwarf with a vary much crazy elf comanion) this will do nicly

though i quandry about adventure walking stick mod. as it adds walking sticks and you can put a lantern on em im just wondering how the mod handles it as they basicly function like a lanturn but with exstra boons. in ya hand.

gndrneutralnoun

as the mod description says, this mod does not detect dynamic lights. the way i am going to implement wearable lights detection is checking for the item (when you put it in the config) for some attributes if it's toggleable, otherwise it will assume it's always light emitting and will not tick adaptation.

detecting dynamic lights is probably impossible at this time, or at least I have not seen a way to do it.

I have worked on a wearable light detection system which works well, though it is yet to be fully done. I guess I will have to also check backpack slots too, not sure how still useful stuff works. you mention a backpack clip which i assume is something that stays in the backpack slot?

I'll check regardless "later" what the mod you mentioned does, but if you can provide details I can brainstorm some stuff in the meantime.

as for the rift issue, i have noticed it with rustbound magic too, and a bit less with vanilla. probably some shader stuff. i will look into it.

Is anyone else having an issue where rifts tend to pop in and out of view depending on which way you're looking? It's possibly a mod conflict - the only mod I can think of that I have installed that does anything with rifts is Rustbound Magic, though of course it could be something else.

I really like this mod; the only problem is that it doesn't seem to work with the backpack clip from (Still) Useful Stuff. I get the desaturation effect when the only light around is via my backpack clip. It meshes well with playing as a kobold or other PML model that you can interpret as having better night vision than seraphs do, since you can make it so that you have better night vision without the unrealistic aspect of being able to see in perfect color in the dark.

JStarling3

not sure what your issue is. light should not flicker even if you set the adaptation rate to near instant.

probably some hardware related shader stuff.

if you care enough, send me a video on discord or ping me on the game's discord with a video attached.

Having issues with flashing. Not very playable with the lighting flickering constantly with every change. Not sure what makes it happen. Cool in concept if fixed

Vanra

can be done. I already check if the player is wearing the vanilla night vision helmet and disable adaptation. can expose this so it can be configured and you can add any modded wearable sources.

Would you consider making Fueled Wearable Lights compatible? 
Right now dark Vision still work even with lamps on making light overblown.

frogblaster

it's kind of already a feature. you can crank exposure multiplier and exposure lag and have a similar effect.

though I might make a different effect for sunlight exposure that is stronger.

Pentasis

this mod makes brightermoonlight redundant.

as for naturalnight, you may want to disable desaturation or increase desaturation threshold so it only kicks in when its really dark. Otherwise it will desaturate your colors.

both work fine and are compatible.

How does this relate to (overlapping functionality or compatibility) with: https://mods.vintagestory.at/naturalnight and https://mods.vintagestory.at/brightermoonlight ?

would it be possible for future versions to include the reverse, such as exiting a cave causing an almost blinding brightess that needs adjusting to?

now we just need integration with playermodellib to have different races have different low light adaptation